src/array-iterator.js - Issue 338323003: Add @@iterator to Array.prototype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/array-iterator.js

Issue 338323003: Add @@iterator to Array.prototype (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix @@iterator property attributes, add tests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/array-iterator.js

diff --git a/src/array-iterator.js b/src/array-iterator.js

index 9511b6d95a483c6f56395dd5701a0325c530477d..de52922dd187fc354651afb10be958b12a0535a8 100644

--- a/src/array-iterator.js

+++ b/src/array-iterator.js

@@ -111,7 +111,7 @@ function SetUpArrayIterator() {

));

%FunctionSetName(ArrayIteratorIterator, '[Symbol.iterator]');

%SetProperty(ArrayIterator.prototype, symbolIterator, ArrayIteratorIterator,

- DONT_ENUM | DONT_DELETE | READ_ONLY);

+ DONT_ENUM);

}

SetUpArrayIterator();

@@ -124,5 +124,7 @@ function ExtendArrayPrototype() {

'values', ArrayValues,

'keys', ArrayKeys

));

+ %SetProperty($Array.prototype, symbolIterator, ArrayValues, DONT_ENUM);

}

ExtendArrayPrototype();