DevTools: Use TargetsToolbar instead of ThreadToolbar

Source/devtools/front_end/components/ExecutionContextSelector.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {WebInspector.TargetManager.Observer}
  */
-WebInspector.ExecutionContextSelector = function() {
+WebInspector.ExecutionContextSelector = function()
+{
     WebInspector.targetManager.observeTargets(this);
+    WebInspector.context.addFlavorChangeListener(WebInspector.ExecutionContext, this._executionContextChanged, this);
+    WebInspector.context.addFlavorChangeListener(WebInspector.Target, this._targetChanged, this);
 }
 
 WebInspector.ExecutionContextSelector.prototype = {
 
     /**
      * @param {!WebInspector.Target} target
      */
     targetAdded: function(target)
     {
+        if (!WebInspector.context.flavor(WebInspector.Target))
+            WebInspector.context.setFlavor(WebInspector.Target, target);
+
         target.runtimeModel.addEventListener(WebInspector.RuntimeModel.Events.ExecutionContextCreated, this._onExecutionContextCreated, this);
         target.runtimeModel.addEventListener(WebInspector.RuntimeModel.Events.ExecutionContextDestroyed, this._onExecutionContextDestroyed, this);
     },
 
     /**
      * @param {!WebInspector.Target} target
      */
     targetRemoved: function(target)
     {
         target.runtimeModel.removeEventListener(WebInspector.RuntimeModel.Events.ExecutionContextCreated, this._onExecutionContextCreated, this);
         target.runtimeModel.removeEventListener(WebInspector.RuntimeModel.Events.ExecutionContextDestroyed, this._onExecutionContextDestroyed, this);
-        if (WebInspector.context.flavor(WebInspector.ExecutionContext).target() === target)
+        var currentExecutionContext = WebInspector.context.flavor(WebInspector.Target);
+        if (currentExecutionContext && currentExecutionContext.target() === target)
             this._currentExecutionContextGone();
+
+        var targets = WebInspector.targetManager.targets();
+        if (WebInspector.context.flavor(WebInspector.Target) === target && targets.length)
+            WebInspector.context.setFlavor(WebInspector.Target, targets[0]);
     },
 
     /**
+     * @param {!WebInspector.Event} event
+     */
+    _executionContextChanged: function(event)
+    {
+        var newContext = /** @type {?WebInspector.ExecutionContext} */ (event.data);
+        if (newContext)
+            WebInspector.context.setFlavor(WebInspector.Target, newContext.target());
+    },
+
+    /**
+     * @param {!WebInspector.Event} event
+     */
+    _targetChanged: function(event)
+    {
+        var newTarget = /** @type {?WebInspector.Target} */(event.data);
+        var currentContext = WebInspector.context.flavor(WebInspector.ExecutionContext);
+
+        if (!newTarget || currentContext && currentContext.target() === newTarget)

[vsevik, 2014/06/19 07:52:42]

I don't know what "A || B && C" actually does.
Do you? :)

[sergeyv, 2014/06/19 10:54:44]

Yep :)
Done.

+            return;

[vsevik, 2014/06/19 07:52:42]

shouldn't we remove execution context in case there is no selected target
anymore? Is that even possible?

+
+        var executionContexts = newTarget.runtimeModel.executionContexts();
+        if (!executionContexts.length)

[vsevik, 2014/06/19 07:52:42]

Shouldn't we reset execution context?

+            return;
+
+        var newContext = executionContexts[0];
+        for (var i = 1; i < executionContexts.length; ++i) {
+            if (executionContexts[i].isMainWorldContext)
+                newContext = executionContexts[i];
+        }
+        WebInspector.context.setFlavor(WebInspector.ExecutionContext, newContext);
+    },
+
+    /**
      * @param {!WebInspector.Event} event
      */
     _onExecutionContextCreated: function(event)
     {
         var executionContext = /** @type {!WebInspector.ExecutionContext}*/ (event.data);
         if (!WebInspector.context.flavor(WebInspector.ExecutionContext))
             WebInspector.context.setFlavor(WebInspector.ExecutionContext, executionContext);
     },
 
     /**
@@ skipping 35 matching lines @@
         completionsReadyCallback([]);
         return;
     }
 
     // Pass less stop characters to rangeOfWord so the range will be a more complete expression.
     var expressionRange = wordRange.startContainer.rangeOfWord(wordRange.startOffset, " =:[({;,!+-*/&|^<>", proxyElement, "backward");
     var expressionString = expressionRange.toString();
     var prefix = wordRange.toString();
     executionContext.completionsForExpression(expressionString, prefix, force, completionsReadyCallback);
 }