Issue 338273002: Split UNPACKING_FAILED exit code out from UNCOMPRESSION_FAILED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338273002: Split UNPACKING_FAILED exit code out from UNCOMPRESSION_FAILED. (Closed)

Created:
6 years, 6 months ago by grt (UTC plus 2)

Modified:
6 years, 6 months ago

Reviewers:
gab

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Split UNPACKING_FAILED exit code out from UNCOMPRESSION_FAILED. To ease failure diagnosis. BUG=385421 R=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277780

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/installer/setup/setup_main.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/installer/util/util_constants.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

gab

lgtm, does Omaha need to be updated to be aware of this or does it ...

6 years, 6 months ago (2014-06-17 15:33:51 UTC) #2

grt (UTC plus 2)

On 2014/06/17 15:33:51, gab wrote: > lgtm, does Omaha need to be updated to be ...

6 years, 6 months ago (2014-06-17 15:37:18 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/338273002/20001

6 years, 6 months ago (2014-06-17 15:38:39 UTC) #5

Message was sent while issue was closed.

Change committed as 277780