Fix the position of drag thumbnail when the scale settings is not 100%.

Fix the position of drag thumbnail when the scale settings is not 100%.

The thumbnail of an image file is a squared image. This is implemented as an
image in a square container. The non square image is cropped
by the square container, but the hidden part of the image causes unwated
position gap of the dragging thumbnail.

Previously we handle the gap by adding 1000px padding for the thumbnail. But the
padding causes another bug when the browser is shown in non 100% scale. This CL
stops to add 1000px padding. Instead, to handle the unwanted gap, the CL let
Files.app copy the image to a square canvas. For the solution, we don't need to
crop an image by a square canvas because the canvas itself is square, and thus we
are free from position gap problem.

BUG=339179
TEST=manually
R=mtomasz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277993

[hirono, 2014-06-17 04:28:59]

PTAL the CL? Thank you!

[mtomasz, 2014-06-17 04:42:35]

https://codereview.chromium.org/338253003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/css/file_manager.css (right):

https://codereview.chromium.org/338253003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/css/file_manager.css:1332: line-height:
0;
nit: What is the purpose of this change?

https://codereview.chromium.org/338253003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/338253003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:416:
entry, ThumbnailLoader.LoaderType, Image, metadata);
nit: LoaderType, Image -> LoaderType.Image?

https://codereview.chromium.org/338253003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:467:
canvas.width = 64;
nit: Move 64 to a constant? Used in several in 8 places.

[hirono, 2014-06-17 04:50:53]

Thanks!

https://codereview.chromium.org/338253003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/css/file_manager.css (right):

https://codereview.chromium.org/338253003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/css/file_manager.css:1332: line-height:
0;
On 2014/06/17 04:42:34, mtomasz wrote:
> nit: What is the purpose of this change?

This is for avoiding unwanted spaces.
Because canvas is inline-block, it is placed in a line.
If the line height is default value, the line-height is calculated as more than
64px, and it causes the unwanted space.

https://codereview.chromium.org/338253003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/338253003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:416:
entry, ThumbnailLoader.LoaderType, Image, metadata);
On 2014/06/17 04:42:34, mtomasz wrote:
> nit: LoaderType, Image -> LoaderType.Image?

Oops, Done.

https://codereview.chromium.org/338253003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:467:
canvas.width = 64;
On 2014/06/17 04:42:34, mtomasz wrote:
> nit: Move 64 to a constant? Used in several in 8 places.

Done.

[mtomasz, 2014-06-17 04:52:51]

lgtm!

[hirono, 2014-06-17 04:55:20]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-06-17 04:56:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/338253003/20001

[commit-bot: I haz the power, 2014-06-17 11:12:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 11:12:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[hirono, 2014-06-18 05:37:25]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-06-18 05:39:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/338253003/40001

[hirono, 2014-06-18 05:39:29]

The CQ bit was unchecked by hirono@chromium.org

[hirono, 2014-06-18 05:40:10]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-06-18 05:42:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/338253003/40001

[hirono, 2014-06-18 08:44:58]

Committed patchset #3 manually as r277993 (presubmit successful).