DescriptionRevert of Revert of Support casting for embedded YT videos (https://codereview.chromium.org/339613002/)
Reason for revert:
Re-landing casting embedded YT feature.
Original issue's description:
> Revert of Support casting for embedded YT videos (https://codereview.chromium.org/302453012/)
>
> Reason for revert:
> It appears to break compile on android:
>
> ../../media/base/android/media_source_player_unittest.cc: In constructor 'media::MediaSourcePlayerTest::MediaSourcePlayerTest()':
> ../../media/base/android/media_source_player_unittest.cc:172:40:error: no matching function for call to 'media::MediaSourcePlayer::MediaSourcePlayer(int, media::MockMediaPlayerManager*, base::Callback<void(int)>, base::Callback<void(int)>, scoped_ptr<media::DemuxerAndroid>)'
> surface_texture_a_is_next_(true) {}
> ^
> ../../media/base/android/media_source_player_unittest.cc:172:40: note: candidates are:
> In file included from ../../base/basictypes.h:18:0,
> from ../../media/base/android/media_source_player_unittest.cc:7:
> ../../media/base/android/media_source_player.h:269:28: note: media::MediaSourcePlayer::MediaSourcePlayer(const media::MediaSourcePlayer&)
> DISALLOW_COPY_AND_ASSIGN(MediaSourcePlayer);
> ^
> ../../base/macros.h:29:3: note: in definition of macro 'DISALLOW_COPY_AND_ASSIGN'
> TypeName(const TypeName&); \
> ^
> ../../media/base/android/media_source_player.h:269:28: note: candidate expects 1 argument, 5 provided
> DISALLOW_COPY_AND_ASSIGN(MediaSourcePlayer);
> ^
> ../../base/macros.h:29:3: note: in definition of macro 'DISALLOW_COPY_AND_ASSIGN'
> TypeName(const TypeName&); \
> ^
> In file included from ../../media/base/android/media_source_player_unittest.cc:15:0:
> ../../media/base/android/media_source_player.h:41:3: note: media::MediaSourcePlayer::MediaSourcePlayer(int, media::MediaPlayerManager*, const RequestMediaResourcesCB&, const ReleaseMediaResourcesCB&, scoped_ptr<media::DemuxerAndroid>, const GURL&)
> MediaSourcePlayer(int player_id,
> ^
> ../../media/base/android/media_source_player.h:41:3: note: candidate expects 6 arguments, 5 provided
> ninja: build stopped: subcommand failed.
>
>
> Original issue's description:
> > Support casting for embedded YT videos
> >
> > This is part 1 of the code to start supporting embedded YT for cast. The main
> > issue is that YT embedded videos need to be identified via the frame that
> > contains it. This CL sets the frame URL of each video in the MediaPlayerAndroid
> > object.
> >
> > NOTRY=true
> >
> > Clank downstream piece to come later.
> > Min / Aaron: will send you the doc I have that explains this in more detail.
> >
> > BUG=358573
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277425
>
> NOTRY=true
> NOTREECHECK=true
> TBR=maybelle@chromium.org
TBR=qinmin@chromium.org,acolwell@chromium.org,avayvod@chromium.org,aberent@chromium.org,mfoltz@chromium.org,miguelg@chromium.org,cpalmer@chromium.org,binjin@chromium.org
Patch Set 1 #
Created: 6 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 9 (0 generated)
|