tools/android/adb_profile_chrome/perf_controller.py - Issue 338233003: Telemetry: Set scaling governor on all cpus (on all devices)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/adb_profile_chrome/perf_controller.py

Issue 338233003: Telemetry: Set scaling governor on all cpus (on all devices) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/perf/perf_control_unittest.py ('K') | « build/android/pylib/perf/perf_control_unittest.py ('k') | tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/android/adb_profile_chrome/perf_controller.py

diff --git a/tools/android/adb_profile_chrome/perf_controller.py b/tools/android/adb_profile_chrome/perf_controller.py

index 523fb855ff1156999b4ca1b129145ea9a5d60305..1012f4a1e6fb65be15e1ba116fffea35a21fec66 100644

--- a/tools/android/adb_profile_chrome/perf_controller.py

+++ b/tools/android/adb_profile_chrome/perf_controller.py

@@ -58,7 +58,7 @@ class _PerfProfiler(object):

if categories:

cmd += ['--event', ','.join(categories)]

self._perf_control = perf_control.PerfControl(self._device)

- self._perf_control.ForceAllCpusOnline(True)

+ self._perf_control.ForceHighPerfMode(True)

Sami 2014/06/19 18:12:43 True should be removed, right? BTW, tools/android

epenner 2014/06/19 23:58:50 Thanks. I ran the above and the other test manuall

self._perf_process = subprocess.Popen(cmd,

stdout=self._log_file,

stderr=subprocess.STDOUT)

@@ -67,7 +67,7 @@ class _PerfProfiler(object):

perf_pids = self._device.old_interface.ExtractPid('perf')

self._device.RunShellCommand('kill -SIGINT ' + ' '.join(perf_pids))

self._perf_process.wait()

- self._perf_control.ForceAllCpusOnline(False)

+ self._perf_control.SetDefaultPerfMode()

def _FailWithLog(self, msg):

self._log_file.seek(0)