Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 338213004: Oilpan: Trace SVGFontFaceElement::m_fontElement. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Oilpan: Trace SVGFontFaceElement::m_fontElement. m_fontElement is a parent element. It's ok to use a strong reference. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/core/svg/SVGFontFaceElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-17 01:57:47 UTC) #1
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-06-17 02:01:58 UTC) #2
kouhei (in TOK)
The CQ bit was unchecked by kouhei@chromium.org
6 years, 6 months ago (2014-06-17 02:02:00 UTC) #3
kouhei (in TOK)
lgtm
6 years, 6 months ago (2014-06-17 02:02:07 UTC) #4
haraken
LGTM
6 years, 6 months ago (2014-06-17 02:07:53 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-17 02:11:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/338213004/1
6 years, 6 months ago (2014-06-17 02:11:42 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 04:33:57 UTC) #8
Message was sent while issue was closed.
Change committed as 176280

Powered by Google App Engine
This is Rietveld 408576698