Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 338203002: Refine bench_record and bench_playback: (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Refine bench_record and bench_playback: - use high-precision wall timer only - warm caches once before measuring - measure independent samples, calculating statistics - add --verbose to control how much data we output Also removed some unloved features from bench_record. BUG=skia: Committed: https://skia.googlesource.com/skia/+/90c471e73fb0bd09aef8ad1e3f0842e5d46fb342

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -65 lines) Patch
M bench/BenchTimer.h View 1 chunk +20 lines, -3 lines 0 comments Download
M bench/BenchTimer.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
A tools/Stats.h View 1 chunk +32 lines, -0 lines 0 comments Download
M tools/bench_playback.cpp View 4 chunks +49 lines, -19 lines 2 comments Download
M tools/bench_record.cpp View 5 chunks +80 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
These tools are similar to some modes in bench_pictures, but stand alone mostly because I ...
6 years, 6 months ago (2014-06-16 19:51:57 UTC) #1
jcgregorio
https://codereview.chromium.org/338203002/diff/1/tools/bench_playback.cpp File tools/bench_playback.cpp (right): https://codereview.chromium.org/338203002/diff/1/tools/bench_playback.cpp#newcode78 tools/bench_playback.cpp:78: draw(*record, *picture, canvas.get()); I know there was talk of ...
6 years, 6 months ago (2014-06-16 20:12:48 UTC) #2
mtklein
https://codereview.chromium.org/338203002/diff/1/tools/bench_playback.cpp File tools/bench_playback.cpp (right): https://codereview.chromium.org/338203002/diff/1/tools/bench_playback.cpp#newcode78 tools/bench_playback.cpp:78: draw(*record, *picture, canvas.get()); On 2014/06/16 20:12:48, jcgregorio wrote: > ...
6 years, 6 months ago (2014-06-16 20:21:28 UTC) #3
mtklein
On 2014/06/16 20:21:28, mtklein wrote: > https://codereview.chromium.org/338203002/diff/1/tools/bench_playback.cpp > File tools/bench_playback.cpp (right): > > https://codereview.chromium.org/338203002/diff/1/tools/bench_playback.cpp#newcode78 > ...
6 years, 6 months ago (2014-06-16 20:29:45 UTC) #4
jcgregorio
On 2014/06/16 20:29:45, mtklein wrote: > On 2014/06/16 20:21:28, mtklein wrote: > > https://codereview.chromium.org/338203002/diff/1/tools/bench_playback.cpp > ...
6 years, 6 months ago (2014-06-16 20:42:37 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-16 20:52:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/338203002/1
6 years, 6 months ago (2014-06-16 20:53:14 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 21:04:48 UTC) #8
Message was sent while issue was closed.
Change committed as 90c471e73fb0bd09aef8ad1e3f0842e5d46fb342

Powered by Google App Engine
This is Rietveld 408576698