Add semantics to apply gpu blakclist to AMD swichable when a discrete/integrated GPU is in use

Add semantics to apply gpu blakclist to AMD swichable when a discrete/integrated GPU is in use

BUG=376562
TEST=gpu_unittests
R=kbr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278703

[Zhenyao Mo, 2014-06-19 23:01:40]

kbr: please review.

[Ken Russell (switch to Gerrit), 2014-06-19 23:31:03]

LGTM

https://codereview.chromium.org/338183005/diff/1/gpu/config/gpu_control_list_...
File gpu/config/gpu_control_list_format.txt (right):

https://codereview.chromium.org/338183005/diff/1/gpu/config/gpu_control_list_...
gpu/config/gpu_control_list_format.txt:29: //      c)
"amd_swicthable_integrated": AMD dual GPU, integrated GPU is active
typo: switchable

https://codereview.chromium.org/338183005/diff/1/gpu/config/gpu_control_list_...
gpu/config/gpu_control_list_format.txt:31: //    c) and d) are only valid on
Win, as on Mac we can switch GPU on the fly.
Would be nicer if these new additions could be handled by multi_gpu_category
somehow. Might be simpler, but but also might be more confusing. It's already
pretty hard to understand how multi_gpu_style and multi_gpu_category work
together. Something to consider; not necessary make a change.

[Zhenyao Mo, 2014-06-19 23:56:33]

https://codereview.chromium.org/338183005/diff/1/gpu/config/gpu_control_list_...
File gpu/config/gpu_control_list_format.txt (right):

https://codereview.chromium.org/338183005/diff/1/gpu/config/gpu_control_list_...
gpu/config/gpu_control_list_format.txt:29: //      c)
"amd_swicthable_integrated": AMD dual GPU, integrated GPU is active
On 2014/06/19 23:31:02, Ken Russell wrote:
> typo: switchable

Done.

https://codereview.chromium.org/338183005/diff/1/gpu/config/gpu_control_list_...
gpu/config/gpu_control_list_format.txt:31: //    c) and d) are only valid on
Win, as on Mac we can switch GPU on the fly.
On 2014/06/19 23:31:02, Ken Russell wrote:
> Would be nicer if these new additions could be handled by multi_gpu_category
> somehow. Might be simpler, but but also might be more confusing. It's already
> pretty hard to understand how multi_gpu_style and multi_gpu_category work
> together. Something to consider; not necessary make a change.

multi_gpu_style is not a qualifier for a specific GPU, whereas
multi_gpu_category is a qualifier to a specific GPU. Let me ruminate further on
how to make it more intuitive to understand.

[Zhenyao Mo, 2014-06-19 23:56:59]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2014-06-19 23:57:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zmo@chromium.org/338183005/20001

[commit-bot: I haz the power, 2014-06-20 08:22:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-20 13:56:57]

Change committed as 278703