Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 338123002: Qualify the generated includes in core (part 4) (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, philipj_slow, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, Rik, nessy, aandrey+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Qualify the generated includes in core (part 4) This CL takes care the rest part of html subdirs under core. BUG=381876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -75 lines) Patch
M Source/core/html/ImageData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LinkRelAttribute.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LinkRelAttributeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/Canvas2DContextAttributes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseButtonInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseCheckableInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/BaseTextInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/ButtonInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/CheckboxInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/ColorInputType.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/DateInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/DateTimeLocalInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/EmailInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/HiddenInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/ImageInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/MonthInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/PasswordInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/RadioInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/ResetInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/SearchInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/StepRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/SubmitInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TelephoneInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TimeInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/URLInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/WeekInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeNumericFieldElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DetailsMarkerControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MeterShadowElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/ProgressShadowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SliderThumbElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrack.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/BufferedLineReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/vtt/VTTElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTParser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
c.shu
6 years, 6 months ago (2014-06-16 15:00:26 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-16 15:17:34 UTC) #2
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-16 15:18:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/338123002/1
6 years, 6 months ago (2014-06-16 15:19:35 UTC) #4
haraken
tasak@ and nbarth@ are aiming at completely breaking the dependency from core/ to modules/ in ...
6 years, 6 months ago (2014-06-16 15:19:55 UTC) #5
c.shu
On 2014/06/16 15:19:55, haraken wrote: > tasak@ and nbarth@ are aiming at completely breaking the ...
6 years, 6 months ago (2014-06-16 15:29:16 UTC) #6
commit-bot: I haz the power
Change committed as 176216
6 years, 6 months ago (2014-06-16 16:05:36 UTC) #7
Nils Barth (inactive)
6 years, 6 months ago (2014-06-17 04:13:04 UTC) #8
Message was sent while issue was closed.
On 2014/06/16 15:29:16, c.shu wrote:
> this include change is endless. :)

...and you are tireless ;)
Thanks!

Powered by Google App Engine
This is Rietveld 408576698