Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 338113002: DevTools: Added user warning for chrome://inspect/#devices in Incognito. (Closed)

Created:
6 years, 6 months ago by vkuzkokov
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

DevTools: Added user warning for chrome://inspect/#devices in Incognito. BUG=372306 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/resources/inspect/inspect.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vkuzkokov
6 years, 6 months ago (2014-06-16 13:15:39 UTC) #1
Vladislav Kaznacheev
lgtm
6 years, 6 months ago (2014-06-17 10:14:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/338113002/1
6 years, 6 months ago (2014-06-17 10:16:27 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 14:15:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/18063)
6 years, 6 months ago (2014-06-17 14:15:10 UTC) #5
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 6 months ago (2014-06-17 16:52:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/338113002/1
6 years, 6 months ago (2014-06-17 16:52:54 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 17:54:34 UTC) #8
Message was sent while issue was closed. 
Change committed as 277799

Powered by Google App Engine
This is Rietveld 408576698