Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Issue 338103004: Use metadata for patching. (Closed)

Created:
6 years, 6 months ago by Johnni Winther
Modified:
6 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+627 lines, -490 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 chunks +6 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/patch_parser.dart View 9 chunks +38 lines, -167 lines 0 comments Download
M sdk/lib/_internal/lib/async_patch.dart View 3 chunks +14 lines, -7 lines 0 comments Download
M sdk/lib/_internal/lib/collection_patch.dart View 8 chunks +34 lines, -22 lines 0 comments Download
M sdk/lib/_internal/lib/convert_patch.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M sdk/lib/_internal/lib/core_patch.dart View 10 chunks +133 lines, -71 lines 0 comments Download
M sdk/lib/_internal/lib/internal_patch.dart View 1 chunk +9 lines, -5 lines 0 comments Download
M sdk/lib/_internal/lib/io_patch.dart View 5 chunks +252 lines, -131 lines 0 comments Download
M sdk/lib/_internal/lib/isolate_patch.dart View 9 chunks +39 lines, -19 lines 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/math_patch.dart View 2 chunks +27 lines, -14 lines 0 comments Download
M sdk/lib/_internal/lib/mirrors_patch.dart View 2 chunks +15 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 25 chunks +44 lines, -44 lines 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
6 years, 6 months ago (2014-06-16 13:53:50 UTC) #1
karlklose
LGTM.
6 years, 6 months ago (2014-06-17 12:33:57 UTC) #2
Johnni Winther
6 years, 6 months ago (2014-06-17 13:09:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37392 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698