Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 338103003: Password bubble: Ensure that the bubble stays open for at least 1 second. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
index 7e1b67e0a1b8f53e4a6523e3ae46f1f4db8551d1..55dfb2a394b7a56f637f872b03e6498bba3f70ab 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
#include "base/memory/scoped_vector.h"
+#include "base/timer/elapsed_timer.h"
#include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/password_form_manager.h"
#include "components/password_manager/core/browser/password_store.h"
@@ -139,6 +140,11 @@ class ManagePasswordsUIController
// |password_form_map_|.
GURL origin_;
+ // Used to measure the amount of time on a page; if it's less than some
+ // reasonable limit, then don't close the bubble upon navigation. We create
+ // (and destroy) the timer in DidNavigateMainFrame.
+ scoped_ptr<base::ElapsedTimer> timer_;
+
DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
};

Powered by Google App Engine
This is Rietveld 408576698