Password bubble: Ensure that the bubble stays open for at least 1 second.

chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_MOCK_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_MOCK_H_
 
 #include "base/basictypes.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "components/password_manager/core/common/password_manager_ui.h"
+#include "content/public/browser/navigation_details.h"
 
 namespace content {
 class WebContents;
 }  // namespace content
 
 // This mock is used in tests to ensure that we're just testing the controller
 // behavior, and not the behavior of the bits and pieces it relies upon (like
 // FormManager).
 class ManagePasswordsUIControllerMock
     : public ManagePasswordsUIController {
@@ skipping 19 matching lines @@
   bool never_saved_password() const { return never_saved_password_; }
 
   virtual const autofill::PasswordForm& PendingCredentials() const OVERRIDE;
 
   // Sneaky setters for testing.
   void SetPasswordFormMap(const autofill::PasswordFormMap& map) {
     password_form_map_ = map;
   }
   void SetState(password_manager::ui::State state) { state_ = state; }
 
+  void SetTimer(base::ElapsedTimer* timer) { timer_.reset(timer); }
+
   // True if this controller is installed on |web_contents()|.
   bool IsInstalled() const;
 
+  virtual void DidNavigateMainFrame(

[vabr (Chromium), 2014/06/17 09:46:25]

nit: Instead of manually declaring the parent's method here, and calling it in
the *.cc file, just replace the declaration with:
using ManagePasswordsUIController::DidNavigateMainFrame;

That will have the same effect, but be shorted and more readable.

[Mike West, 2014/06/17 10:49:35]

C++ is an amazing language. I'm not sure that's a positive statement. :)

Thanks!

+      const content::LoadCommittedDetails& details,
+      const content::FrameNavigateParams& params) OVERRIDE;
+
  private:
   bool navigated_to_settings_page_;
   bool saved_password_;
   bool never_saved_password_;
 
   autofill::PasswordForm pending_credentials_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIControllerMock);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_MOCK_H_