Password bubble: Ensure that the bubble stays open for at least 1 second.

chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browsing_data/browsing_data_helper.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
@@ skipping 153 matching lines @@
       GetPasswordStore(web_contents());
   if (password_store)
     password_store->RemoveLogin(*password_form_map_.begin()->second);
   state_ = password_manager::ui::MANAGE_STATE;
   UpdateBubbleAndIconVisibility();
 }
 
 void ManagePasswordsUIController::DidNavigateMainFrame(
     const content::LoadCommittedDetails& details,
     const content::FrameNavigateParams& params) {
+  // Don't do anything if a navigation occurs before a user could reasonably
+  // interact with the password bubble.
+  if (timer_ && timer_->Elapsed() < base::TimeDelta::FromSeconds(1))

[vabr (Chromium), 2014/06/16 15:02:00]

optional nit: You could make the 1 a named global constant; maybe consider
joining that with kMinimumPromptDisplayTime?

+    return;
+
+  // Don't react to in-page (fragment) navigations.
   if (details.is_in_page)

[vabr (Chromium), 2014/06/16 15:02:00]

optional nit: As the cheapest check, this should probably be first.

     return;
+
+  // Otherwise, reset the password manager and the timer.
   state_ = password_manager::ui::INACTIVE_STATE;
   UpdateBubbleAndIconVisibility();
+  timer_.reset(new base::ElapsedTimer());
 }
 
 const autofill::PasswordForm& ManagePasswordsUIController::
     PendingCredentials() const {
   DCHECK(form_manager_);
   return form_manager_->pending_credentials();
 }
 
 void ManagePasswordsUIController::UpdateIconAndBubbleState(
     ManagePasswordsIcon* icon) {
@@ skipping 20 matching lines @@
     return;
   CommandUpdater* updater = browser->command_controller()->command_updater();
   updater->ExecuteCommand(IDC_MANAGE_PASSWORDS_FOR_PAGE);
 #endif
 }
 
 bool ManagePasswordsUIController::PasswordPendingUserDecision() const {
   return state_ == password_manager::ui::PENDING_PASSWORD_STATE ||
          state_ == password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE;
 }