Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2215)

Unified Diff: chrome/browser/prefs/chrome_pref_service_factory.cc

Issue 338093007: Flip Finch Configs so we can harden DSE w/o extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/chrome_pref_service_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/chrome_pref_service_factory.cc
diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc
index 951726a800f6c579a017cec2c4f13c44ac07b1ac..dac7e80e7c9fc709ebf35f897b00f81a40787457 100644
--- a/chrome/browser/prefs/chrome_pref_service_factory.cc
+++ b/chrome/browser/prefs/chrome_pref_service_factory.cc
@@ -185,8 +185,8 @@ enum SettingsEnforcementGroup {
GROUP_NO_ENFORCEMENT,
// Enforce protected settings on profile loads.
GROUP_ENFORCE_ALWAYS,
- // Also enforce extension settings.
- GROUP_ENFORCE_ALWAYS_WITH_EXTENSIONS,
+ // Also enforce extension default search.
+ GROUP_ENFORCE_ALWAYS_WITH_DSE,
// Also enforce extension settings and default search.
GROUP_ENFORCE_ALWAYS_WITH_EXTENSIONS_AND_DSE,
// The default enforcement group contains all protection features.
@@ -217,8 +217,8 @@ SettingsEnforcementGroup GetSettingsEnforcementGroup() {
{ chrome_prefs::internals::kSettingsEnforcementGroupEnforceAlways,
GROUP_ENFORCE_ALWAYS },
{ chrome_prefs::internals::
- kSettingsEnforcementGroupEnforceAlwaysWithExtensions,
- GROUP_ENFORCE_ALWAYS_WITH_EXTENSIONS },
+ kSettingsEnforcementGroupEnforceAlwaysWithDSE,
+ GROUP_ENFORCE_ALWAYS_WITH_DSE },
{ chrome_prefs::internals::
kSettingsEnforcementGroupEnforceAlwaysWithExtensionsAndDSE,
GROUP_ENFORCE_ALWAYS_WITH_EXTENSIONS_AND_DSE },
@@ -267,7 +267,13 @@ GetTrackingConfiguration() {
data.enforcement_level = PrefHashFilter::NO_ENFORCEMENT;
}
- if (enforcement_group >= GROUP_ENFORCE_ALWAYS_WITH_EXTENSIONS &&
+ if (enforcement_group >= GROUP_ENFORCE_ALWAYS_WITH_DSE &&
+ data.name == DefaultSearchManager::kDefaultSearchProviderDataPrefName) {
+ // Specifically enable default search settings enforcement.
+ data.enforcement_level = PrefHashFilter::ENFORCE_ON_LOAD;
+ }
+
+ if (enforcement_group >= GROUP_ENFORCE_ALWAYS_WITH_EXTENSIONS_AND_DSE &&
(data.name == extensions::pref_names::kExtensions ||
data.name == extensions::pref_names::kKnownDisabled)) {
// Specifically enable extension settings enforcement and ensure
@@ -276,12 +282,6 @@ GetTrackingConfiguration() {
data.enforcement_level = PrefHashFilter::ENFORCE_ON_LOAD;
}
- if (enforcement_group >= GROUP_ENFORCE_ALWAYS_WITH_EXTENSIONS_AND_DSE &&
- data.name == DefaultSearchManager::kDefaultSearchProviderDataPrefName) {
- // Specifically enable default search settings enforcement.
- data.enforcement_level = PrefHashFilter::ENFORCE_ON_LOAD;
- }
-
result.push_back(data);
}
return result;
@@ -391,8 +391,8 @@ namespace internals {
const char kSettingsEnforcementTrialName[] = "SettingsEnforcement";
const char kSettingsEnforcementGroupNoEnforcement[] = "no_enforcement";
const char kSettingsEnforcementGroupEnforceAlways[] = "enforce_always";
-const char kSettingsEnforcementGroupEnforceAlwaysWithExtensions[] =
- "enforce_always_with_extensions";
+const char kSettingsEnforcementGroupEnforceAlwaysWithDSE[] =
+ "enforce_always_with_dse";
const char kSettingsEnforcementGroupEnforceAlwaysWithExtensionsAndDSE[] =
"enforce_always_with_extensions_and_dse";
« no previous file with comments | « chrome/browser/prefs/chrome_pref_service_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698