Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 338093007: Flip Finch Configs so we can harden DSE w/o extensions (Closed)

Created:
6 years, 6 months ago by Cait (Slow)
Modified:
6 years, 6 months ago
Reviewers:
gab
CC:
chromium-reviews, robertshield, erikwright (departed)
Visibility:
Public.

Description

Flip Finch Configs so we can harden DSE w/o extensions BUG=385318 TEST=test manually that new finch groups behave as expected. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277790

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/first_run/first_run_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 5 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Cait (Slow)
Gab - PTAL.
6 years, 6 months ago (2014-06-16 18:49:49 UTC) #1
gab
lgtm, create issue 385318 for tracking and added it to this issue; CQ'ing now. Thanks! ...
6 years, 6 months ago (2014-06-16 22:22:49 UTC) #2
gab
The CQ bit was checked by gab@chromium.org
6 years, 6 months ago (2014-06-16 22:22:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/338093007/1
6 years, 6 months ago (2014-06-16 22:45:14 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 02:44:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/22912) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/17559)
6 years, 6 months ago (2014-06-17 02:44:56 UTC) #6
Cait (Slow)
The CQ bit was checked by caitkp@chromium.org
6 years, 6 months ago (2014-06-17 14:30:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/338093007/20001
6 years, 6 months ago (2014-06-17 14:31:24 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 17:18:14 UTC) #9
Message was sent while issue was closed.
Change committed as 277790

Powered by Google App Engine
This is Rietveld 408576698