Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 338093005: Cache the GrEffect used for text rendering in GrBitmapTextContext. (Closed)

Created:
6 years, 6 months ago by bsalomon
Modified:
6 years, 6 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Cache the GrEffect used for text rendering in GrBitmapTextContext. Committed: https://skia.googlesource.com/skia/+/8b2fac4b25dfb8180c54707f8e19698a9fddde07

Patch Set 1 #

Patch Set 2 : Fix init order #

Patch Set 3 : add cpp file #

Patch Set 4 : rebase #

Patch Set 5 : simplify getGenerationID #

Total comments: 2

Patch Set 6 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -10 lines) Patch
M gyp/gpu.gypi View 2 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrCacheable.h View 1 2 2 chunks +12 lines, -2 lines 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 2 3 4 5 1 chunk +7 lines, -5 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 2 3 4 5 2 chunks +9 lines, -3 lines 0 comments Download
A src/gpu/GrCacheable.cpp View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 6 months ago (2014-06-18 14:01:04 UTC) #1
jvanverth1
lgtm + one suggestion https://codereview.chromium.org/338093005/diff/80001/src/gpu/GrBitmapTextContext.h File src/gpu/GrBitmapTextContext.h (right): https://codereview.chromium.org/338093005/diff/80001/src/gpu/GrBitmapTextContext.h#newcode52 src/gpu/GrBitmapTextContext.h:52: uint32_t fEFfectTextureGenID; Typo: fEFfect ->fEffect
6 years, 6 months ago (2014-06-19 19:06:05 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 6 months ago (2014-06-19 19:31:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/338093005/100001
6 years, 6 months ago (2014-06-19 19:31:50 UTC) #4
bsalomon
https://codereview.chromium.org/338093005/diff/80001/src/gpu/GrBitmapTextContext.h File src/gpu/GrBitmapTextContext.h (right): https://codereview.chromium.org/338093005/diff/80001/src/gpu/GrBitmapTextContext.h#newcode52 src/gpu/GrBitmapTextContext.h:52: uint32_t fEFfectTextureGenID; On 2014/06/19 19:06:04, jvanverth1 wrote: > Typo: ...
6 years, 6 months ago (2014-06-19 19:32:21 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 21:13:53 UTC) #6
Message was sent while issue was closed. 
Change committed as 8b2fac4b25dfb8180c54707f8e19698a9fddde07

Powered by Google App Engine
This is Rietveld 408576698