Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 338093004: New avatar menu cleanup: Move supervised user disclaimer into appropriate position. (Closed)

Created:
6 years, 6 months ago by Marc Treib
Modified:
6 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

New avatar menu cleanup: Move supervised user disclaimer into appropriate position. Should be below accounts list, but above list of other profiles. BUG=372812, 372381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Marc Treib
PTAL!
6 years, 6 months ago (2014-06-16 15:51:29 UTC) #1
msw
before/after screenshots would be nice, but lgtm.
6 years, 6 months ago (2014-06-16 18:13:05 UTC) #2
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-17 07:52:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/338093004/1
6 years, 6 months ago (2014-06-17 07:55:35 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 15:20:12 UTC) #5
Message was sent while issue was closed.
Change committed as 277771

Powered by Google App Engine
This is Rietveld 408576698