Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 338063002: Temporary workaround to trigger a rebuild of libicudata_nacl on icu version update (Closed)

Created:
6 years, 6 months ago by jungshik at Google
Modified:
6 years, 6 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, Sorin Jianu
Visibility:
Public.

Description

Temporary workaround to trigger a rebuild of libicudata_nacl on icu version update When ICU was rolled from icu4.6 to icu52, libicudata_nacl was not rebuilt on some build bots leading to an undefined symbol linker error (icudt52_dat not found). By making icudata_nacl target explicitly depend on uvernum.h, we can force icudata_nacl target to be rebuilt when there's an ICU version change. (a work-around suggested by Sergey). A more fundamental fix is to change the way nacl targets determine its dependencies See https://codereview.chromium.org/336993003/ BUG=132145 TEST=After rolling icu to 52, incremental build will not complain about missing symbol (icudt52_dat). R=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277885

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M icu_nacl.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
Hi Sergey, Thank you for suggesting this work around. Can you take a look?
6 years, 6 months ago (2014-06-16 08:13:42 UTC) #1
jungshik at Google
Ping, Sergey :-) Thanks
6 years, 6 months ago (2014-06-17 17:29:37 UTC) #2
Sergey Ulanov
lgtm
6 years, 6 months ago (2014-06-17 18:15:10 UTC) #3
jungshik at Google
6 years, 6 months ago (2014-06-17 22:29:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r277885 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698