Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 338053003: [Arm]: Fix liveedit support if --enable_ool_constant_pool is true. (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev, alph
Project:
v8
Visibility:
Public.

Description

[Arm]: Fix liveedit support if --enable_ool_constant_pool is true. If the out of line constant pool is enabled, there is an extra value on the stack frame (the constant pool pointer). This change fixes GenerateFrameDropperLiveEdit to pull the function pointer and pop the stack frame correctly whether or not the constant pool pointer is on the frame. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M src/arm/debug-arm.cc View 1 chunk +16 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
Yang, please take a look, thanks.
6 years, 5 months ago (2014-06-27 15:05:31 UTC) #1
Yang
On 2014/06/27 15:05:31, rmcilroy wrote: > Yang, please take a look, thanks. lgtm. Thanks.
6 years, 5 months ago (2014-06-30 07:32:36 UTC) #2
rmcilroy
6 years, 5 months ago (2014-06-30 11:06:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698