Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 33803002: MIPS: Add tool to visualize machine code/lithium. (Closed)

Created:
7 years, 2 months ago by palfia
Modified:
7 years, 2 months ago
Reviewers:
kisg, Paul Lind, kilvadyb, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Add tool to visualize machine code/lithium. Port r17295 (b36eb655) Original commit message: In the process: - Add a command-line flag --opt-code-positions to track source position information throughout optimized code. - Add a subclass of the hydrogen graph builder to ensure that the source position is properly set on the graph builder for all generated hydrogen code. - Overhaul handling of source positions in hydrogen to ensure they are passed through to generated code consistently and in most cases transparently. BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=17305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -39 lines) Patch
M src/mips/lithium-codegen-mips.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 8 chunks +6 lines, -20 lines 0 comments Download
M src/mips/lithium-mips.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
7 years, 2 months ago (2013-10-21 21:39:44 UTC) #1
Paul Lind
LGTM. I did notice an odd thing in CallCodeGeneric(), but it is unrelated to this ...
7 years, 2 months ago (2013-10-21 22:17:51 UTC) #2
palfia
7 years, 2 months ago (2013-10-21 22:20:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698