Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 338023002: Added parser part of all shorthand property. (Closed)

Created:
6 years, 6 months ago by tasak
Modified:
6 years, 6 months ago
Reviewers:
esprehn, dglazkov, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Project:
blink
Visibility:
Public.

Description

Added parser part of all shorthand property. - added "all" property to CSSProperties.in and so on. - added "unset" CSSValue. "unset" is defined in all spec. all spec: http://dev.w3.org/csswg/css-cascade/#all-shorthand BUG=172051 TEST=fast/css/all-shorthand-css-text.html,fast/css/all-shorthand.html,fast/css/getComputedStyle/getComputedStyle-all.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176289

Patch Set 1 #

Patch Set 2 : Fixed patch conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -14 lines) Patch
M LayoutTests/fast/css/all-shorthand-css-text-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-all-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 3 chunks +16 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tasak
Would you review this CL? This depends on https://codereview.chromium.org/335733003/. However, I think this patch could ...
6 years, 6 months ago (2014-06-16 07:16:50 UTC) #1
dglazkov
lgtm
6 years, 6 months ago (2014-06-16 15:29:41 UTC) #2
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 6 months ago (2014-06-16 15:30:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/338023002/1
6 years, 6 months ago (2014-06-16 15:30:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 15:30:57 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/css/all-shorthand-css-text-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; The next ...
6 years, 6 months ago (2014-06-16 15:30:58 UTC) #6
tasak
Thank you for reviewing. I fixed the patch conflict.
6 years, 6 months ago (2014-06-17 06:01:35 UTC) #7
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-06-17 06:01:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/338023002/20001
6 years, 6 months ago (2014-06-17 06:02:25 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 07:13:59 UTC) #10
Message was sent while issue was closed.
Change committed as 176289

Powered by Google App Engine
This is Rietveld 408576698