Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 338015: Changed button text to conform with GNOME HIG.... (Closed)

Created:
11 years, 1 month ago by Ramkumar Ramachandra
Modified:
9 years, 7 months ago
Reviewers:
tony, mattm
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Changed button text to conform with GNOME HIG. BUG=18076 TEST=Compile and see label

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/edit_search_engine_dialog.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Ramkumar Ramachandra
Hey, kindly review this quick patch.
11 years, 1 month ago (2009-10-26 13:43:05 UTC) #1
tony
Have you signed the electronic CLA? http://code.google.com/legal/individual-cla-v1.0.html
11 years, 1 month ago (2009-10-26 21:13:23 UTC) #2
Ramkumar Ramachandra
Yes.
11 years, 1 month ago (2009-10-27 08:12:55 UTC) #3
tony
LGTM, I will land the patch for you. Thanks for doing this!
11 years, 1 month ago (2009-10-27 17:10:38 UTC) #4
Ramkumar Ramachandra
Thanks! Should we also close the corresponding bug?
11 years, 1 month ago (2009-10-27 17:39:11 UTC) #5
tony
11 years, 1 month ago (2009-10-27 17:45:04 UTC) #6
Committed in r30214.

Powered by Google App Engine
This is Rietveld 408576698