Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337973004: DevTools protocol: add emulateNetworkConditions parameters. (Closed)

Created:
6 years, 6 months ago by eustas
Modified:
6 years, 6 months ago
Reviewers:
vsevik, dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools protocol: add emulateNetworkConditions parameters. BUG=245436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176211

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M Source/devtools/protocol.json View 1 chunk +5 lines, -2 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
eustas
6 years, 6 months ago (2014-06-16 09:00:32 UTC) #1
dgozman
https://codereview.chromium.org/337973004/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/337973004/diff/1/Source/devtools/protocol.json#newcode1168 Source/devtools/protocol.json:1168: { "name": "maximalThroughput", "type": "number", "description": "Deprecated." }, Why ...
6 years, 6 months ago (2014-06-16 10:23:52 UTC) #2
vsevik
lgtm
6 years, 6 months ago (2014-06-16 11:31:47 UTC) #3
eustas
https://codereview.chromium.org/337973004/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/337973004/diff/1/Source/devtools/protocol.json#newcode1168 Source/devtools/protocol.json:1168: { "name": "maximalThroughput", "type": "number", "description": "Deprecated." }, On ...
6 years, 6 months ago (2014-06-16 13:04:44 UTC) #4
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-16 13:04:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/337973004/1
6 years, 6 months ago (2014-06-16 13:05:57 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 14:09:37 UTC) #7
Message was sent while issue was closed. 
Change committed as 176211

Powered by Google App Engine
This is Rietveld 408576698