Issue 337963002: Remove inefficiency from HTMLCollection::namedItems()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337963002: Remove inefficiency from HTMLCollection::namedItems() (Closed)

Created:
6 years, 6 months ago by Inactive

Modified:
6 years, 6 months ago

Reviewers:
esprehn, adamk

CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Remove inefficiency from HTMLCollection::namedItems() Remove inefficiency from HTMLCollection::namedItems(). The code was unnecessarily checking that the pointers were non-null for every iteration of the for loops. This CL updates the code so that the null check is done only once. R=esprehn@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176247

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	Source/core/html/HTMLCollection.cpp	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/337963002/1

6 years, 6 months ago (2014-06-16 20:18:36 UTC) #4

Message was sent while issue was closed.

Change committed as 176247