Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 337923007: [Chromedriver] Convert Git hash to svn revision if required. (Closed)

Created:
6 years, 6 months ago by pshenoy
Modified:
6 years, 6 months ago
Reviewers:
stgao
CC:
chromium-reviews, stgao, anantha
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Convert Git hash to svn revision if required. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278870

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M chrome/test/chromedriver/run_buildbot_steps.py View 1 2 2 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pshenoy
6 years, 6 months ago (2014-06-20 20:56:45 UTC) #1
pshenoy
Hi Shuotao, As discussed, I have modified the script. Please take a look.
6 years, 6 months ago (2014-06-20 22:41:31 UTC) #2
stgao
lgtm once the single comment is addressed. https://codereview.chromium.org/337923007/diff/20001/chrome/test/chromedriver/run_buildbot_steps.py File chrome/test/chromedriver/run_buildbot_steps.py (right): https://codereview.chromium.org/337923007/diff/20001/chrome/test/chromedriver/run_buildbot_steps.py#newcode391 chrome/test/chromedriver/run_buildbot_steps.py:391: print 'HTTP ...
6 years, 6 months ago (2014-06-20 22:58:18 UTC) #3
pshenoy
https://codereview.chromium.org/337923007/diff/20001/chrome/test/chromedriver/run_buildbot_steps.py File chrome/test/chromedriver/run_buildbot_steps.py (right): https://codereview.chromium.org/337923007/diff/20001/chrome/test/chromedriver/run_buildbot_steps.py#newcode391 chrome/test/chromedriver/run_buildbot_steps.py:391: print 'HTTP Error %d' % error.getcode() On 2014/06/20 22:58:17, ...
6 years, 6 months ago (2014-06-20 23:04:08 UTC) #4
pshenoy
The CQ bit was checked by pshenoy@chromium.org
6 years, 6 months ago (2014-06-20 23:04:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/337923007/40001
6 years, 6 months ago (2014-06-20 23:08:13 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 23:53:01 UTC) #7
Message was sent while issue was closed.
Change committed as 278870

Powered by Google App Engine
This is Rietveld 408576698