Issue 337923006: Change WebTimeRange to use doubles instead of floats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337923006: Change WebTimeRange to use doubles instead of floats. (Closed)

Created:
6 years, 6 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Change WebTimeRange to use doubles instead of floats. All the Chromium-side code that creates WebTimeRanges uses doubles and all the Blink-side code that consumes WebTimeRanges use doubles, but somehow this class didn't get updated. This change fixes the problem so that values don't get truncated to the float range as they pass through a WebTimeRange. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176664

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	public/platform/WebTimeRange.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/337923006/1

6 years, 6 months ago (2014-06-20 23:39:57 UTC) #4

Message was sent while issue was closed.

Change committed as 176664

Expand Messages | Collapse Messages