Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 337903004: Adds support for running analyzer from gyp_chromium (Closed)

Created:
6 years, 6 months ago by sky
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Adds support for running analyzer from gyp_chromium Analyzer is going to be used to determine if a set of files effects any of the dependencies for a bot. BUG=383609 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279309

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M build/gyp_chromium View 1 2 chunks +18 lines, -10 lines 1 comment Download

Messages

Total messages: 14 (1 generated)
sky
6 years, 6 months ago (2014-06-23 17:58:03 UTC) #1
Nico
Looks fine, but the CL description looks like it was meant for a different change.
6 years, 6 months ago (2014-06-23 18:01:47 UTC) #2
sky
GAH! Sorry about that. Fixed.
6 years, 6 months ago (2014-06-23 18:05:51 UTC) #3
Nico
lgtm
6 years, 6 months ago (2014-06-23 18:06:41 UTC) #4
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-23 18:14:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/337903004/20001
6 years, 6 months ago (2014-06-23 18:18:11 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-23 22:34:33 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 01:29:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/31359)
6 years, 6 months ago (2014-06-24 01:29:40 UTC) #9
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-24 02:36:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/337903004/20001
6 years, 6 months ago (2014-06-24 02:37:12 UTC) #11
commit-bot: I haz the power
Change committed as 279309
6 years, 6 months ago (2014-06-24 04:14:24 UTC) #12
kjellander_chromium
5 years, 2 months ago (2015-09-28 17:43:05 UTC) #14
Message was sent while issue was closed.
I got a question about the non-copying of the VS runtime DLLs.

https://codereview.chromium.org/337903004/diff/20001/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/337903004/diff/20001/build/gyp_chromium#newco...
build/gyp_chromium:323: if not use_analyzer:
May I ask why it's skipping copying of the runtime DLLs when using the analyzer?
It seems unrelated but I guess it's an optimization?

What I'm worried about is if a fresh trybot machine with no previous checkout is
told to run analyze-enabled tryjobs always. Will it not be missing these DLLs
then, potentially causing problems during test execution?
(I'm not entirely sure what really needs the DLLs though)

Powered by Google App Engine
This is Rietveld 408576698