Revert of Bring Syzygy binaries in using a script rather than as a dependency.

Revert of Bring Syzygy binaries in using a script rather than as a dependency. (https://codereview.chromium.org/306543006/)

Reason for revert:
This break the SyzyASan LKGR build because this doesn't put syzyasan_rtl.dll.pdb
. While it's not a file so useful for the developers (they can get the symbols
on the symbol server) we put them in the SyzyASan LKGR archives. We could
probably remove it from them, but I have to check if i's used by Clusterfuzz
first... I'll revert this CL in the meantime.

Original issue's description:
> Bring Syzygy binaries in using a script rather than as a dependency.
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273353
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277048

[Sébastien Marchand, 2014-06-15 02:26:05]

Created Revert of Bring Syzygy binaries in using a script rather than as a
dependency.

[commit-bot: I haz the power, 2014-06-15 02:27:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/337903002/1

[commit-bot: I haz the power, 2014-06-15 02:27:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-15 02:27:04]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Sébastien Marchand, 2014-06-15 02:28:45]

I can't commit this one until I get a lgtm from a committer (I'll be committer
in a few days only...)

[chrisha, 2014-06-15 02:47:26]

How about just fixing the script instead of the revert?
On Jun 14, 2014 10:28 PM, <sebmarchand@chromium.org> wrote:

> I can't commit this one until I get a lgtm from a committer (I'll be
> committer
> in a few days only...)
>
> https://codereview.chromium.org/337903002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sébastien Marchand, 2014-06-15 04:16:03]

By the time I'll fix it etc (probably not until Monday afternoon) there
won't be a new SyzyASan build, which is bad for Clusterfuzz (for the
regression ranges etc).
Le 2014-06-14 22:47, "Chris Hamilton" <chrisha@chromium.org> a écrit :

> How about just fixing the script instead of the revert?
> On Jun 14, 2014 10:28 PM, <sebmarchand@chromium.org> wrote:
>
>> I can't commit this one until I get a lgtm from a committer (I'll be
>> committer
>> in a few days only...)
>>
>> https://codereview.chromium.org/337903002/
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chrisha, 2014-06-15 15:18:32]

The fix to the script is pretty simple, and doing it that way actually lets us
test if things work well when the script re-downloads and overwrites. The fix
lives here:

https://codereview.chromium.org/334093002/

[Sébastien Marchand, 2014-06-15 15:31:13]

Thanks, we'll discuss with Abhishek to see if we really need to embed the PDBs
in the archives.