Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: LayoutTests/fast/media/media-query-list-listener.html

Issue 337883003: Call media query change listeners asynchronously. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix typo Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/media/media-query-list-listener.html
diff --git a/LayoutTests/fast/media/media-query-list-listener.html b/LayoutTests/fast/media/media-query-list-listener.html
index fb348f3ca8b9136e4b8cc36abe3f06f6e3d7ef80..df631f84cd818e410b5598a9a9a8e65d980be8be 100644
--- a/LayoutTests/fast/media/media-query-list-listener.html
+++ b/LayoutTests/fast/media/media-query-list-listener.html
@@ -5,9 +5,7 @@
<script>
description("Media query listeners should fire on changes to matches status.");
-
- if (window.testRunner)
- testRunner.dumpAsText();
+ var jsTestIsAsync = true;
var sandbox = document.getElementById("sandbox");
var iframe = document.createElement("iframe");
@@ -17,36 +15,47 @@
var mediaList = matchMedia("(max-width: 100px)");
var expectedValue = "";
+ var tests = [];
+ var currentTest = 0;
+ function runNextTest() {
+ tests[currentTest++]();
+ }
function listener(list) {
window.mediaListArgument = list;
shouldBe("mediaList", "mediaListArgument");
shouldBe("mediaList.matches", expectedValue);
+ runNextTest();
}
mediaList.addListener(listener);
shouldBe("mediaList.matches", "true");
- // FIXME: You shouldn't need to touch offsetTop to force these updates.
-
// Should fire.
iframe.style.width = "200px";
expectedValue = "false";
- iframe.offsetTop;
-
- // Should not fire.
- iframe.style.width = "250px";
- expectedValue = "false";
- iframe.offsetTop;
-
- // Should fire.
- iframe.style.width = "80px";
- expectedValue = "true";
- iframe.offsetTop;
- // Should not fire.
- mediaList.removeListener(listener);
- iframe.style.width = "200px";
- iframe.offsetTop;
- shouldBe("mediaList.matches", "false");
+ tests.push(function() {
+ // Should not fire.
+ iframe.style.width = "250px";
+ expectedValue = "false";
+
+ setTimeout(runNextTest, 20);
+ });
+
+ tests.push(function() {
+ // Should fire.
+ iframe.style.width = "80px";
+ expectedValue = "true";
+ });
+
+ tests.push(function() {
+ // Should not fire.
+ mediaList.removeListener(listener);
+ iframe.style.width = "200px";
+ iframe.offsetTop;
+ shouldBe("mediaList.matches", "false");
+
+ setTimeout(finishJSTest, 20);
+ });
</script>

Powered by Google App Engine
This is Rietveld 408576698