Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337873003: Qualify the generated includes in core (part 5) (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, aandrey+blink_chromium.org, caseq+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, nessy, loislo+blink_chromium.org, philipj_slow, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, Nate Chapin, vcarbune.chromium, gavinp+prerender_chromium.org, gasubic, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Qualify the generated includes in core (part 5) This CL takes care the inspector and loader subdirs under core. BUG=381876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176234

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M Source/core/inspector/ConsoleMessage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ContentSearchUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScript.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptCanvasModule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorBaseAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorCanvasInstrumentation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorConsoleInstrumentation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorMemoryAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlayHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorRuntimeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InstrumentingAgents.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ScriptCallFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ScriptCallStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ScriptProfile.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/TimelineRecordFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/BeaconLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FormSubmission.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/LinkLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/NavigationPolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/PingLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/TextTrackLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
c.shu
6 years, 6 months ago (2014-06-16 16:07:16 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-16 16:44:48 UTC) #2
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-16 17:03:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/337873003/20001
6 years, 6 months ago (2014-06-16 17:05:03 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 19:26:17 UTC) #5
Message was sent while issue was closed. 
Change committed as 176234

Powered by Google App Engine
This is Rietveld 408576698