Support basic reading of focus for both desktop and tabs trees.

Support basic reading of focus for both desktop and tabs trees.

This implements:
- basic spoken and braille feedback on tabs and desktop trees.
- gives us a conceptual outline of the three entry points to interact with ChromeVox next:
1. keyboard (right now only possible by DOM events delivered through the content script)
2. through events received from the tabs automation tree
3.  through events received from the desktop automation tree
- test added against production ChromeVox for status tray.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278682

[Peter Lundblad, 2014-06-19 20:54:10]

lgtm with comments

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js
(right):

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js:11:
function ChromeVoxE2ETest() {}
nit: @constructor

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js:12:
ChromeVoxE2ETest.prototype = {
nit: blank line.

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.extjs
(right):

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.extjs:55:
function SYNC_TEST_F(testFixture, testName, testFunction) {
nit: jsdoc.  Also, move to the base class right away?  Seems frameworky to me.

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.extjs:69:
/** Tests ChromeVox next is in this context. */
nit: Tests that (I find it easier to read that way;)

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js
(right):

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:24:
// Register listeners for ...
How would you feel about breaking the registration of event listeners out into
its own function right away.  Seems like that could grow a bit further.

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:28:
// Tabs.
nit: indentation.

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:73:
* @param {Object} changeInfo Information about the updated tab.
Is there a better type for this, or should we have an extern typedef?

[David Tseng, 2014-06-19 22:30:38]

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js
(right):

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js:11:
function ChromeVoxE2ETest() {}
On 2014/06/19 20:54:10, Peter Lundblad wrote:
> nit: @constructor

Done. (are we/will we supporting closure compile/static analysis of test files
as well)?

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js:12:
ChromeVoxE2ETest.prototype = {
On 2014/06/19 20:54:10, Peter Lundblad wrote:
> nit: blank line.

Done.

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.extjs
(right):

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.extjs:55:
function SYNC_TEST_F(testFixture, testName, testFunction) {
On 2014/06/19 20:54:10, Peter Lundblad wrote:
> nit: jsdoc.  Also, move to the base class right away?  Seems frameworky to me.

Done.

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.extjs:69:
/** Tests ChromeVox next is in this context. */
On 2014/06/19 20:54:10, Peter Lundblad wrote:
> nit: Tests that (I find it easier to read that way;)

Done. (and below).

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js
(right):

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:24:
// Register listeners for ...
On 2014/06/19 20:54:10, Peter Lundblad wrote:
> How would you feel about breaking the registration of event listeners out into
> its own function right away.  Seems like that could grow a bit further.

I think there actually should only be three (desktop, tabs, and keyboard); each
of those will register lots of listeners I think.

I guess if it grows any larger, we should break it out then.

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:28:
// Tabs.
On 2014/06/19 20:54:10, Peter Lundblad wrote:
> nit: indentation.

Done.

https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:73:
* @param {Object} changeInfo Information about the updated tab.
On 2014/06/19 20:54:10, Peter Lundblad wrote:
> Is there a better type for this, or should we have an extern typedef?

Check out
chrome/common/extensions/api/tabs.json

I'm just worried it will get out of sync with this. We should do this properly I
think by generating the externs from the json/idl.

[Peter Lundblad, 2014-06-19 22:55:25]

dtseng@chromium.org writes:
> 
>
https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
> File
> chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js
> (right):
> 
>
https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
> chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js:11:
> function ChromeVoxE2ETest() {}
> On 2014/06/19 20:54:10, Peter Lundblad wrote:
> > nit: @constructor
> 
> Done. (are we/will we supporting closure compile/static analysis of test
> files as well)?

I think we could if we fel it's worth it (could catch some 'forgot to  update
the
text' bugs before going to the bots).  It'd require a small amount of work,
which
I am not doing right now.  OTOH, the chromium style guide still prefers jsdoc.
If we want to not use jsdoc in tests, let's make a decision on that soon and
stick to it.

>
https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
>
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:73:
> * @param {Object} changeInfo Information about the updated tab.
> On 2014/06/19 20:54:10, Peter Lundblad wrote:
> > Is there a better type for this, or should we have an extern typedef?
> 
> Check out
> chrome/common/extensions/api/tabs.json
> 
> I'm just worried it will get out of sync with this. We should do this
> properly I think by generating the externs from the json/idl.

I think it's an excellent idea to generate externs from the one true source,but
if we start saying Object, we'll probably end up with that sticking for a long
while.  I wouldn't be too worried about our externs getting out of sync
for already public APIs, but it could obviously happen over time.

//peter

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2014-06-20 02:52:17]

On 2014/06/19 22:55:25, Peter Lundblad wrote:
> mailto:dtseng@chromium.org writes:
> > 
> >
>
https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
> > File
> > chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js
> > (right):
> > 
> >
>
https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
> >
chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test.js:11:
> > function ChromeVoxE2ETest() {}
> > On 2014/06/19 20:54:10, Peter Lundblad wrote:
> > > nit: @constructor
> > 
> > Done. (are we/will we supporting closure compile/static analysis of test
> > files as well)?
> 
> I think we could if we fel it's worth it (could catch some 'forgot to  update
> the
> text' bugs before going to the bots).  It'd require a small amount of work,
> which
> I am not doing right now.  OTOH, the chromium style guide still prefers jsdoc.
> If we want to not use jsdoc in tests, let's make a decision on that soon and
> stick to it.
> 
> >
>
https://codereview.chromium.org/337843005/diff/60001/chrome/browser/resources...
> >
>
chrome/browser/resources/chromeos/chromevox2/cvox2/background/background.js:73:
> > * @param {Object} changeInfo Information about the updated tab.
> > On 2014/06/19 20:54:10, Peter Lundblad wrote:
> > > Is there a better type for this, or should we have an extern typedef?
> > 
> > Check out
> > chrome/common/extensions/api/tabs.json
> > 
> > I'm just worried it will get out of sync with this. We should do this
> > properly I think by generating the externs from the json/idl.
> 
> I think it's an excellent idea to generate externs from the one true
source,but
> if we start saying Object, we'll probably end up with that sticking for a long
> while.  I wouldn't be too worried about our externs getting out of sync
> for already public APIs, but it could obviously happen over time.

I added the basic type Object.<string, string|boolean> (but not to externs). All
keys are optional, so seems only marginly valuable to add to externs.

> 
> //peter
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2014-06-20 02:53:37]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-06-20 02:57:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtseng@chromium.org/337843005/80001

[commit-bot: I haz the power, 2014-06-20 12:07:05]

Change committed as 278682