Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 337803006: Modify safe-browsing to use mobile-specific client strings. (Closed)

Created:
6 years, 6 months ago by Scott Hess - ex-Googler
Modified:
6 years, 6 months ago
Reviewers:
noé, noelutz, Brian Ryner
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Modify safe-browsing to use mobile-specific client strings. Identify Android vs iOS requests so that server can adjust respond differently to mobile hits than desktop. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Scott Hess - ex-Googler
Let me know if/when this is safe to go.
6 years, 6 months ago (2014-06-16 22:53:48 UTC) #1
noelutz
lgtm
6 years, 6 months ago (2014-06-17 17:23:23 UTC) #2
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 6 months ago (2014-06-17 17:40:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/337803006/1
6 years, 6 months ago (2014-06-17 17:42:17 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 23:42:46 UTC) #5
Message was sent while issue was closed.
Change committed as 277904

Powered by Google App Engine
This is Rietveld 408576698