Backoff: Respect maximum delay in face of float overflow

net/base/backoff_entry_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/backoff_entry.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 using base::TimeDelta;
@@ skipping 275 matching lines @@
   // Regression test for a bug discovered during code review.
   BackoffEntry::Policy lenient_policy = base_policy;
   lenient_policy.num_errors_to_ignore = 1;
   TestBackoffEntry custom(&lenient_policy);
   TimeTicks custom_horizon = TimeTicks() + TimeDelta::FromDays(3);
   custom.SetCustomReleaseTime(custom_horizon);
   custom.InformOfRequest(false);  // This must not reset the horizon.
   EXPECT_EQ(custom_horizon, custom.GetReleaseTime());
 }
 
+TEST(BackoffEntryTest, OverflowProtection) {
+  TestBackoffEntry custom(&base_policy);
+
+  // Trigger enough failures such that more than 11 bits of exponent are used
+  // to represent the exponential backoff intermediate values.

[cbentzel, 2014/06/14 15:16:07]

Could you use a different policy for this test with a larger
multiplication_factor to reduce the number of cycles needed to reach overflow?

[Nicolas Zea, 2014/06/16 20:27:25]

Done.

+  for (size_t i = 0; i < (1 << 11); ++i) {
+     custom.set_now(custom.ImplGetTimeNow() + custom.GetTimeUntilRelease());
+     custom.InformOfRequest(false);
+     EXPECT_TRUE(custom.ShouldRejectRequest());
+  }
+
+  // Max delay should still be respected.
+  EXPECT_EQ(20000, custom.GetTimeUntilRelease().InMilliseconds());
+}
+
 }  // namespace