Repaint squashing content in cases where the entire frame is repainting.

Repaint squashing content in cases where the entire frame is repainting.

In the process, inline RenderLayerRepainter::setBackingNeedsRepaint's one call site
and remove the method.

BUG=384520
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176150

[chrishtr, 2014-06-13 20:15:17]

I have no test. This CL is part of a cleanup of compositing/non-compositing code
to find potential squashing bugs. If you think it's best to invest the time I
can try to find test cases.

This code is triggered in miscellaneous special cases:

updateLayerPositionsAfterLayout is called with the full-repaint flag if one of
these is true:
 * "first" layout of a view. "first" can be reset if scrollbars change.
 * If RenderView:: shouldDoFullRepaintForNextLayout returns true. The
conditions when it does are a collection of fun / obscure special cases.

RenderLayerCompositor:: repaintCompositedLayers is called if the style resolver
changes on the document.

[abarth-chromium, 2014-06-13 22:14:01]

LGTM

https://codereview.chromium.org/337793004/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderLayer.cpp (right):

https://codereview.chromium.org/337793004/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLayer.cpp:305: // performance?
Because this code is crazy.

https://codereview.chromium.org/337793004/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLayer.cpp:309:
compositedLayerMapping()->setSquashingContentsNeedDisplay();
Are there any callers of setContentsNeedDisplay() that don't want to call
setSquashingContentsNeedDisplay()?  Perhaps setContentsNeedDisplay() should do
the work of setSquashingContentsNeedDisplay() as well.

[chrishtr, 2014-06-13 22:48:33]

https://codereview.chromium.org/337793004/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderLayer.cpp (right):

https://codereview.chromium.org/337793004/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLayer.cpp:309:
compositedLayerMapping()->setSquashingContentsNeedDisplay();
On 2014/06/13 22:14:01, abarth wrote:
> Are there any callers of setContentsNeedDisplay() that don't want to call
> setSquashingContentsNeedDisplay()?  Perhaps setContentsNeedDisplay() should do
> the work of setSquashingContentsNeedDisplay() as well.

Yes, there is one, which is why I didn't do it that way. In particular,
CompositedLayerMapping::updateFilters(). I don't want to
over-invalidate.

[chrishtr, 2014-06-13 22:48:36]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-06-13 22:48:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishtr@chromium.org/337793004/1

[commit-bot: I haz the power, 2014-06-14 00:03:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-14 00:03:17]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11400)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/16840)

[chrishtr, 2014-06-14 02:01:06]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-06-14 02:01:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishtr@chromium.org/337793004/20001

[commit-bot: I haz the power, 2014-06-14 03:02:42]

Change committed as 176150