Issue 337793003: ServiceWorker: Spec alignment tweaks for Request/Response objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337793003: ServiceWorker: Spec alignment tweaks for Request/Response objects (Closed)

Created:
6 years, 6 months ago by jsbell

Modified:
6 years, 6 months ago

Reviewers:
falken, horo

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

ServiceWorker: Spec alignment tweaks for Request/Response objects Request.method should be ByteString (now supported) Response.status should be assignable Response.statusText should be assignable Response.statusText should be ByteString (now supported) And added tests for assignable properties/invalid ByteStrings. R=falken@chromium.org,horo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176148

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -7 lines)			Patch
M	LayoutTests/http/tests/serviceworker/resources/request-worker.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/response-worker.js	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/modules/serviceworkers/Request.idl	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/modules/serviceworkers/RequestInit.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/serviceworkers/Response.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/modules/serviceworkers/Response.idl	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	Source/modules/serviceworkers/ResponseInit.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jsbell

Minor tweaks that may already be in in-flight patches elsewhere. falken@ or horo@ - please ...

6 years, 6 months ago (2014-06-13 18:55:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/337793003/1

6 years, 6 months ago (2014-06-14 01:19:06 UTC) #4

Message was sent while issue was closed.

Change committed as 176148

Expand Messages | Collapse Messages