Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 337783007: Rename TestSize.cpp to SkSizeTest.cpp (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rename TestSize.cpp to SizeTest.cpp It is the only file where Test is the prefix rather than the sufix. This patch fixes that so it matches with the rest of the files under tests/ directory. And separate SkISize test into its own DEF_TEST(). BUG=None TEST=make tests && out/Debug/tests R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/12345aee12daffe96dbc9c77056e797d91c78d3e

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : SizeTest.cpp #

Total comments: 4

Patch Set 4 : name fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -69 lines) Patch
M gyp/tests.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + tests/SizeTest.cpp View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
D tests/TestSize.cpp View 1 chunk +0 lines, -64 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
6 years, 5 months ago (2014-06-25 15:38:13 UTC) #1
mtklein
Why? We seem to always map SkFoo -> FooTest.
6 years, 5 months ago (2014-06-25 15:41:19 UTC) #2
mtklein
On 2014/06/25 15:41:19, mtklein wrote: > Why? We seem to always map SkFoo -> FooTest. ...
6 years, 5 months ago (2014-06-25 15:46:26 UTC) #3
tfarina
On 2014/06/25 15:46:26, mtklein wrote: > On 2014/06/25 15:41:19, mtklein wrote: > > Why? We ...
6 years, 5 months ago (2014-06-25 15:49:28 UTC) #4
mtklein
https://codereview.chromium.org/337783007/diff/40001/tests/SizeTest.cpp File tests/SizeTest.cpp (right): https://codereview.chromium.org/337783007/diff/40001/tests/SizeTest.cpp#newcode12 tests/SizeTest.cpp:12: DEF_TEST(SkISizeTest, reporter) { ->ISize ? https://codereview.chromium.org/337783007/diff/40001/tests/SizeTest.cpp#newcode34 tests/SizeTest.cpp:34: DEF_TEST(SkSizeTest, reporter) ...
6 years, 5 months ago (2014-06-25 15:53:59 UTC) #5
tfarina
https://codereview.chromium.org/337783007/diff/40001/tests/SizeTest.cpp File tests/SizeTest.cpp (right): https://codereview.chromium.org/337783007/diff/40001/tests/SizeTest.cpp#newcode12 tests/SizeTest.cpp:12: DEF_TEST(SkISizeTest, reporter) { On 2014/06/25 15:53:58, mtklein wrote: > ...
6 years, 5 months ago (2014-06-25 15:56:01 UTC) #6
mtklein
lgtm
6 years, 5 months ago (2014-06-25 15:58:15 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-06-25 17:27:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/337783007/50001
6 years, 5 months ago (2014-06-25 17:27:46 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-06-25 17:39:07 UTC) #10
Message was sent while issue was closed.
Change committed as 12345aee12daffe96dbc9c77056e797d91c78d3e

Powered by Google App Engine
This is Rietveld 408576698