DevTools: Preload HTML documents content before fetching resource content.

DevTools: Preload HTML documents content before fetching resource content.

This is a last step in fixing the issue of HTML document content being unavailable when DevTools is first opened.
This patch adds HTML document content fetching logic as well as fixing all the tests that somehow depend on it.

BUG=354447
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177538

[vsevik, 2014-06-20 16:34:23]

PTAL

[pfeldman, 2014-06-26 16:46:15]

lgtm

[pfeldman, 2014-06-26 16:50:22]

eseidel@ sees everything.

[vsevik, 2014-06-26 16:55:42]

Nate, could you please review this?

Eric, did you mean to say something? :)

[eseidel, 2014-06-26 16:58:15]

Nope, just ccing nate.  Mostly "preload" caught my eye, but these aren't actual
preload requests. :)

[Nate Chapin, 2014-07-01 02:22:06]

https://codereview.chromium.org/337783003/diff/1/Source/core/loader/FrameLoad...
File Source/core/loader/FrameLoader.h (right):

https://codereview.chromium.org/337783003/diff/1/Source/core/loader/FrameLoad...
Source/core/loader/FrameLoader.h:193: bool
requestFromHistoryForInspector(ResourceRequestCachePolicy, ResourceRequest*);
Let's just make requestFromHistoryItem a public static member of FrameLoader
instead of having this special inspector-specific hook. The inspector should be
able to access and pass in FrameLoader::currentItem() to do so.

[vsevik, 2014-07-01 15:15:07]

On 2014/07/01 02:22:06, Nate Chapin wrote:
>
https://codereview.chromium.org/337783003/diff/1/Source/core/loader/FrameLoad...
> File Source/core/loader/FrameLoader.h (right):
> 
>
https://codereview.chromium.org/337783003/diff/1/Source/core/loader/FrameLoad...
> Source/core/loader/FrameLoader.h:193: bool
> requestFromHistoryForInspector(ResourceRequestCachePolicy, ResourceRequest*);
> Let's just make requestFromHistoryItem a public static member of FrameLoader
> instead of having this special inspector-specific hook. The inspector should
be
> able to access and pass in FrameLoader::currentItem() to do so.

Done, PTAL

[Nate Chapin, 2014-07-01 19:01:33]

LGTM, thanks!

[vsevik, 2014-07-01 20:35:54]

The CQ bit was checked by vsevik@chromium.org

[commit-bot: I haz the power, 2014-07-01 20:36:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vsevik@chromium.org/337783003/20001

[commit-bot: I haz the power, 2014-07-01 21:48:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/13831)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14918)

[commit-bot: I haz the power, 2014-07-01 22:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-01 22:14:10]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[vsevik, 2014-07-04 11:13:26]

The CQ bit was checked by vsevik@chromium.org

[commit-bot: I haz the power, 2014-07-04 11:14:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vsevik@chromium.org/337783003/80001

[commit-bot: I haz the power, 2014-07-04 12:22:07]

Change committed as 177538