Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 337773003: Reland r276815: Add tests for session cache and false start behavior. (Closed)

Created:
6 years, 6 months ago by davidben
Modified:
6 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reland r276815: Add tests for session cache and false start behavior. Was speculatively reverted in https://codereview.chromium.org/332523008/, but it does not appear to be the cause. (ssl_client_socket_unittest.cc is unrelated and tlslite is only used in test server. ChromeAsyncSocketTest does not appear to use the test server. Rather they use mock sockets. Original description: False start should not disable the session cache, but if we never process the server Finished message, the session cannot be resumed. BUG=none Original review URL: https://codereview.chromium.org/301283004 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -30 lines) Patch
M net/socket/ssl_client_socket_unittest.cc View 6 chunks +142 lines, -29 lines 0 comments Download
M third_party/tlslite/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/tlslite/patches/ignore_write_failure.patch View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/tlsrecordlayer.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
davidben
This should be the same as the original CL; I just cherry-picked the commit.
6 years, 6 months ago (2014-06-13 18:48:58 UTC) #1
Ryan Sleevi
lgtm
6 years, 6 months ago (2014-06-13 19:03:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/337773003/1
6 years, 6 months ago (2014-06-13 19:04:45 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-13 23:40:25 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 08:39:06 UTC) #5
Message was sent while issue was closed.
Change committed as 277206

Powered by Google App Engine
This is Rietveld 408576698