Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 337753002: [Telemetry] Use total power measurement calculated by `powermetrics` (Closed)

Created:
6 years, 6 months ago by jeremy
Modified:
6 years, 6 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Use total power measurement calculated by `powermetrics` `powermetrics` reports the total amount of power used over the measurement period in Joules. Use that instead of calculating the number ourselves based on the reported average. Also fix the unit tests. BUG=None R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277065

Patch Set 1 #

Patch Set 2 : More precise math #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py View 1 4 chunks +5 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jeremy
6 years, 6 months ago (2014-06-13 17:51:50 UTC) #1
tonyg
lgtm
6 years, 6 months ago (2014-06-13 17:54:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/337753002/10001
6 years, 6 months ago (2014-06-13 17:56:33 UTC) #3
jeremy
The CQ bit was unchecked by jeremy@chromium.org
6 years, 6 months ago (2014-06-13 17:57:39 UTC) #4
jeremy
6 years, 6 months ago (2014-06-13 19:02:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r277065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698