Issue 337753002: [Telemetry] Use total power measurement calculated by `powermetrics`

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337753002: [Telemetry] Use total power measurement calculated by `powermetrics` (Closed)

Created:
6 years, 6 months ago by jeremy

Modified:
6 years, 6 months ago

Reviewers:
tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Telemetry] Use total power measurement calculated by `powermetrics` `powermetrics` reports the total amount of power used over the measurement period in Joules. Use that instead of calculating the number ourselves based on the reported average. Also fix the unit tests. BUG=None R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277065

Patch Set 1 #

Patch Set 2 : More precise math #

Created: 6 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -15 lines)			Patch
	M	tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py	View	1	4 chunks	+5 lines, -13 lines	0 comments	Download
	M	tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/337753002/10001

6 years, 6 months ago (2014-06-13 17:56:33 UTC) #3

jeremy

6 years, 6 months ago (2014-06-13 19:02:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r277065 (presubmit successful).

Expand Messages | Collapse Messages