GN: Start of //third_party/WebKit/Source/web

GN: Start of //third_party/WebKit/Source/web

The make_file_arrays template should probably go in Source/build/ since it
is also used in modules and on mac I'm getting override errors in clang,
but this is a start. Most things compile.

R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176346

[brettw, 2014-06-17 16:50:39]

lgtm

https://codereview.chromium.org/337703003/diff/1/Source/web/BUILD.gn
File Source/web/BUILD.gn (right):

https://codereview.chromium.org/337703003/diff/1/Source/web/BUILD.gn#newcode24
Source/web/BUILD.gn:24: #"//third_party/WebKit/Source/modules",
It's not clear why this is commented out.

https://codereview.chromium.org/337703003/diff/1/Source/web/BUILD.gn#newcode32
Source/web/BUILD.gn:32: # '<(angle_path)/include',
You can just write //third_party/angle/include here (unless it's not needed?).

https://codereview.chromium.org/337703003/diff/1/Source/web/BUILD.gn#newcode43
Source/web/BUILD.gn:43: defines = [
Instead add "//third_party/WebKit/Source:inside_blink" to the configs list
above. This config defines both of these

[jamesr, 2014-06-17 17:44:11]

On 2014/06/17 16:50:39, brettw wrote:
> lgtm
> 
> https://codereview.chromium.org/337703003/diff/1/Source/web/BUILD.gn
> File Source/web/BUILD.gn (right):
> 
> https://codereview.chromium.org/337703003/diff/1/Source/web/BUILD.gn#newcode24
> Source/web/BUILD.gn:24: #"//third_party/WebKit/Source/modules",
> It's not clear why this is commented out.

GN blows up if you reference /modules/ (see email).  The target definitely needs
to link against modules.

> 
> https://codereview.chromium.org/337703003/diff/1/Source/web/BUILD.gn#newcode32
> Source/web/BUILD.gn:32: # '<(angle_path)/include',
> You can just write //third_party/angle/include here (unless it's not needed?).

I'm not sure it's needed - will either uncomment or remove once I get all the
targets compiling to see.

> 
> https://codereview.chromium.org/337703003/diff/1/Source/web/BUILD.gn#newcode43
> Source/web/BUILD.gn:43: defines = [
> Instead add "//third_party/WebKit/Source:inside_blink" to the configs list
> above. This config defines both of these

Oh cool

[jamesr, 2014-06-17 17:56:11]

I'll move the template to //Source/build/make_file_arrays.gni and land

https://codereview.chromium.org/337703003/diff/1/Source/web/BUILD.gn
File Source/web/BUILD.gn (right):

https://codereview.chromium.org/337703003/diff/1/Source/web/BUILD.gn#newcode32
Source/web/BUILD.gn:32: # '<(angle_path)/include',
On 2014/06/17 16:50:39, brettw wrote:
> You can just write //third_party/angle/include here (unless it's not needed?).

I can't find anything that needs this, so deleting

[jamesr, 2014-06-17 17:57:53]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-06-17 17:59:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/337703003/20001

[commit-bot: I haz the power, 2014-06-17 19:06:11]

Change committed as 176346