Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: cc/trees/single_thread_proxy.cc

Issue 337693005: cc: Control defer_commits logic by Scheduler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/single_thread_proxy.h" 5 #include "cc/trees/single_thread_proxy.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "cc/debug/benchmark_instrumentation.h" 9 #include "cc/debug/benchmark_instrumentation.h"
10 #include "cc/output/context_provider.h" 10 #include "cc/output/context_provider.h"
(...skipping 27 matching lines...) Expand all
38 LayerTreeHostSingleThreadClient* client, 38 LayerTreeHostSingleThreadClient* client,
39 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner, 39 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
40 scoped_ptr<BeginFrameSource> external_begin_frame_source) 40 scoped_ptr<BeginFrameSource> external_begin_frame_source)
41 : Proxy(main_task_runner, NULL), 41 : Proxy(main_task_runner, NULL),
42 layer_tree_host_(layer_tree_host), 42 layer_tree_host_(layer_tree_host),
43 client_(client), 43 client_(client),
44 timing_history_(layer_tree_host->rendering_stats_instrumentation()), 44 timing_history_(layer_tree_host->rendering_stats_instrumentation()),
45 next_frame_is_newly_committed_frame_(false), 45 next_frame_is_newly_committed_frame_(false),
46 inside_draw_(false), 46 inside_draw_(false),
47 defer_commits_(false), 47 defer_commits_(false),
48 commit_was_deferred_(false),
49 commit_requested_(false), 48 commit_requested_(false),
50 inside_synchronous_composite_(false), 49 inside_synchronous_composite_(false),
51 output_surface_creation_requested_(false), 50 output_surface_creation_requested_(false),
52 external_begin_frame_source_(external_begin_frame_source.Pass()), 51 external_begin_frame_source_(external_begin_frame_source.Pass()),
53 weak_factory_(this) { 52 weak_factory_(this) {
54 TRACE_EVENT0("cc", "SingleThreadProxy::SingleThreadProxy"); 53 TRACE_EVENT0("cc", "SingleThreadProxy::SingleThreadProxy");
55 DCHECK(Proxy::IsMainThread()); 54 DCHECK(Proxy::IsMainThread());
56 DCHECK(layer_tree_host); 55 DCHECK(layer_tree_host);
57 } 56 }
58 57
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 return; 301 return;
303 if (defer_commits_ == defer_commits) 302 if (defer_commits_ == defer_commits)
304 return; 303 return;
305 304
306 if (defer_commits) 305 if (defer_commits)
307 TRACE_EVENT_ASYNC_BEGIN0("cc", "SingleThreadProxy::SetDeferCommits", this); 306 TRACE_EVENT_ASYNC_BEGIN0("cc", "SingleThreadProxy::SetDeferCommits", this);
308 else 307 else
309 TRACE_EVENT_ASYNC_END0("cc", "SingleThreadProxy::SetDeferCommits", this); 308 TRACE_EVENT_ASYNC_END0("cc", "SingleThreadProxy::SetDeferCommits", this);
310 309
311 defer_commits_ = defer_commits; 310 defer_commits_ = defer_commits;
312 if (!defer_commits_ && commit_was_deferred_) { 311 scheduler_on_impl_thread_->SetDeferCommits(defer_commits);
313 commit_was_deferred_ = false;
314 BeginMainFrame();
315 }
316 } 312 }
317 313
318 bool SingleThreadProxy::CommitRequested() const { 314 bool SingleThreadProxy::CommitRequested() const {
319 DCHECK(Proxy::IsMainThread()); 315 DCHECK(Proxy::IsMainThread());
320 return commit_requested_; 316 return commit_requested_;
321 } 317 }
322 318
323 bool SingleThreadProxy::BeginMainFrameRequested() const { 319 bool SingleThreadProxy::BeginMainFrameRequested() const {
324 DCHECK(Proxy::IsMainThread()); 320 DCHECK(Proxy::IsMainThread());
325 // If there is no scheduler, then there can be no pending begin frame, 321 // If there is no scheduler, then there can be no pending begin frame,
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 // ThreadProxy::SetNeedsCommit where SetNeedsCommit will not cause a 657 // ThreadProxy::SetNeedsCommit where SetNeedsCommit will not cause a
662 // synchronous commit. 658 // synchronous commit.
663 MainThreadTaskRunner()->PostTask( 659 MainThreadTaskRunner()->PostTask(
664 FROM_HERE, 660 FROM_HERE,
665 base::Bind(&SingleThreadProxy::BeginMainFrame, 661 base::Bind(&SingleThreadProxy::BeginMainFrame,
666 weak_factory_.GetWeakPtr())); 662 weak_factory_.GetWeakPtr()));
667 } 663 }
668 664
669 void SingleThreadProxy::BeginMainFrame() { 665 void SingleThreadProxy::BeginMainFrame() {
670 if (defer_commits_) { 666 if (defer_commits_) {
671 DCHECK(!commit_was_deferred_); 667 TRACE_EVENT_INSTANT0("cc", "EarlyOut_DeferCommit",
672 commit_was_deferred_ = true; 668 TRACE_EVENT_SCOPE_THREAD);
673 layer_tree_host_->DidDeferCommit(); 669 BeginMainFrameAbortedOnImplThread(
670 CommitEarlyOutReason::ABORTED_DEFERRED_COMMIT);
674 return; 671 return;
675 } 672 }
676 673
677 // This checker assumes NotifyReadyToCommit in this stack causes a synchronous 674 // This checker assumes NotifyReadyToCommit in this stack causes a synchronous
678 // commit. 675 // commit.
679 ScopedAbortRemainingSwapPromises swap_promise_checker(layer_tree_host_); 676 ScopedAbortRemainingSwapPromises swap_promise_checker(layer_tree_host_);
680 677
681 if (!layer_tree_host_->visible()) { 678 if (!layer_tree_host_->visible()) {
682 TRACE_EVENT_INSTANT0("cc", "EarlyOut_NotVisible", TRACE_EVENT_SCOPE_THREAD); 679 TRACE_EVENT_INSTANT0("cc", "EarlyOut_NotVisible", TRACE_EVENT_SCOPE_THREAD);
683 BeginMainFrameAbortedOnImplThread( 680 BeginMainFrameAbortedOnImplThread(
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
806 803
807 void SingleThreadProxy::DidBeginImplFrameDeadline() { 804 void SingleThreadProxy::DidBeginImplFrameDeadline() {
808 layer_tree_host_impl_->ResetCurrentBeginFrameArgsForNextFrame(); 805 layer_tree_host_impl_->ResetCurrentBeginFrameArgsForNextFrame();
809 } 806 }
810 807
811 void SingleThreadProxy::SendBeginFramesToChildren(const BeginFrameArgs& args) { 808 void SingleThreadProxy::SendBeginFramesToChildren(const BeginFrameArgs& args) {
812 layer_tree_host_->SendBeginFramesToChildren(args); 809 layer_tree_host_->SendBeginFramesToChildren(args);
813 } 810 }
814 811
815 } // namespace cc 812 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698