Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337643002: Add SwipePage/SwipeElement API to action_runner, wrapping over (Closed)

Created:
6 years, 6 months ago by chrishenry
Modified:
6 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add SwipePage/SwipeElement API to action_runner, wrapping over SwipeAction. SwipeAction now also able to perform swipe on element with selector and text (not just element_function). SwipeAction no longer accepts attributes and instead accept normal parameters. Added unit tests. BUG=361809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277389

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Rebase and address review comment. #

Patch Set 3 : Added missed out automatically_record_interaction flag. #

Total comments: 2

Patch Set 4 : Address more comments. #

Total comments: 2

Patch Set 5 : Address more comment. #

Patch Set 6 : #

Patch Set 7 : Guard test execution so that test doesn't fail in browser that doesn't support touch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -121 lines) Patch
M tools/perf/page_sets/key_silk_cases.py View 1 2 3 4 3 chunks +22 lines, -35 lines 0 comments Download
M tools/perf/page_sets/polymer.py View 1 2 3 1 chunk +17 lines, -26 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 1 2 chunks +48 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 2 3 4 5 6 3 chunks +28 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/swipe.js View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/swipe.py View 1 2 3 2 chunks +39 lines, -48 lines 0 comments Download
A tools/telemetry/unittest_data/page_with_swipeables.html View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
chrishenry
6 years, 6 months ago (2014-06-14 00:52:26 UTC) #1
nednguyen
https://codereview.chromium.org/337643002/diff/40001/tools/telemetry/telemetry/page/actions/action_runner.py File tools/telemetry/telemetry/page/actions/action_runner.py (right): https://codereview.chromium.org/337643002/diff/40001/tools/telemetry/telemetry/page/actions/action_runner.py#newcode217 tools/telemetry/telemetry/page/actions/action_runner.py:217: # element_function (like ClickElement/TapElement. However, rather I am a ...
6 years, 6 months ago (2014-06-14 17:12:13 UTC) #2
chrishenry
https://codereview.chromium.org/337643002/diff/40001/tools/telemetry/telemetry/page/actions/action_runner.py File tools/telemetry/telemetry/page/actions/action_runner.py (right): https://codereview.chromium.org/337643002/diff/40001/tools/telemetry/telemetry/page/actions/action_runner.py#newcode217 tools/telemetry/telemetry/page/actions/action_runner.py:217: # element_function (like ClickElement/TapElement. However, rather On 2014/06/14 17:12:13, ...
6 years, 6 months ago (2014-06-14 17:30:51 UTC) #3
nednguyen
https://codereview.chromium.org/337643002/diff/80001/tools/perf/page_sets/polymer.py File tools/perf/page_sets/polymer.py (right): https://codereview.chromium.org/337643002/diff/80001/tools/perf/page_sets/polymer.py#newcode57 tools/perf/page_sets/polymer.py:57: left_start_percentage=0.1, top_start_percentage=0.2, left_start_ratio? I would want you to also ...
6 years, 6 months ago (2014-06-14 17:46:52 UTC) #4
chrishenry
https://codereview.chromium.org/337643002/diff/80001/tools/perf/page_sets/polymer.py File tools/perf/page_sets/polymer.py (right): https://codereview.chromium.org/337643002/diff/80001/tools/perf/page_sets/polymer.py#newcode57 tools/perf/page_sets/polymer.py:57: left_start_percentage=0.1, top_start_percentage=0.2, On 2014/06/14 17:46:51, nednguyen wrote: > left_start_ratio? ...
6 years, 6 months ago (2014-06-14 17:55:27 UTC) #5
nednguyen
lgtm https://codereview.chromium.org/337643002/diff/100001/tools/perf/page_sets/key_silk_cases.py File tools/perf/page_sets/key_silk_cases.py (right): https://codereview.chromium.org/337643002/diff/100001/tools/perf/page_sets/key_silk_cases.py#newcode287 tools/perf/page_sets/key_silk_cases.py:287: 'Gesture_SwipeAction', is_smooth=True) Use action_runner.BeginGestureInteraction(..) instead?
6 years, 6 months ago (2014-06-15 04:33:54 UTC) #6
chrishenry
https://codereview.chromium.org/337643002/diff/100001/tools/perf/page_sets/key_silk_cases.py File tools/perf/page_sets/key_silk_cases.py (right): https://codereview.chromium.org/337643002/diff/100001/tools/perf/page_sets/key_silk_cases.py#newcode287 tools/perf/page_sets/key_silk_cases.py:287: 'Gesture_SwipeAction', is_smooth=True) On 2014/06/15 04:33:54, nednguyen wrote: > Use ...
6 years, 6 months ago (2014-06-15 07:31:11 UTC) #7
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 6 months ago (2014-06-15 07:32:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/337643002/120001
6 years, 6 months ago (2014-06-15 07:32:45 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-15 09:49:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/41897)
6 years, 6 months ago (2014-06-15 09:49:28 UTC) #11
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 6 months ago (2014-06-15 16:24:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/337643002/140001
6 years, 6 months ago (2014-06-15 16:25:50 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-15 18:53:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/39354)
6 years, 6 months ago (2014-06-15 18:53:16 UTC) #15
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 6 months ago (2014-06-16 04:27:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/337643002/160001
6 years, 6 months ago (2014-06-16 04:27:50 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 09:04:12 UTC) #18
Message was sent while issue was closed. 
Change committed as 277389

Powered by Google App Engine
This is Rietveld 408576698