Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Unified Diff: dart/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dart2js/ProcessRunner.java

Issue 337623003: Version 1.5.0-dev.4.11 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dart2js/ProcessRunner.java
===================================================================
--- dart/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dart2js/ProcessRunner.java (revision 37301)
+++ dart/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dart2js/ProcessRunner.java (working copy)
@@ -108,7 +108,7 @@
final Thread stdoutThread = new Thread(new Runnable() {
@Override
public void run() {
- pipeOutput(process.getInputStream(), stdout);
+ pipeStdout(process.getInputStream(), stdout);
}
});
@@ -116,7 +116,7 @@
final Thread stderrThread = new Thread(new Runnable() {
@Override
public void run() {
- pipeOutput(process.getErrorStream(), stderr);
+ pipeStderr(process.getErrorStream(), stderr);
}
});
@@ -173,7 +173,7 @@
Thread stdoutThread = new Thread(new Runnable() {
@Override
public void run() {
- pipeOutput(process.getInputStream(), stdout);
+ pipeStdout(process.getInputStream(), stdout);
}
});
@@ -181,7 +181,7 @@
Thread stderrThread = new Thread(new Runnable() {
@Override
public void run() {
- pipeOutput(process.getErrorStream(), stderr);
+ pipeStderr(process.getErrorStream(), stderr);
}
});
@@ -233,6 +233,14 @@
}
}
+ protected void pipeStderr(InputStream in, StringBuilder builder) {
+ pipeOutput(in, builder);
+ }
+
+ protected void pipeStdout(InputStream in, StringBuilder builder) {
+ pipeOutput(in, builder);
+ }
+
/**
* To be (optionally) implemented in subclasses. Getting a handle on the started process can be
* useful, for example, if you want to pipe it stdin.

Powered by Google App Engine
This is Rietveld 408576698