Issue 337613008: Instrumented libraries: move build-flags-related logic to the GYP file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337613008: Instrumented libraries: move build-flags-related logic to the GYP file. (Closed)

Created:
6 years, 6 months ago by earthdok

Modified:
6 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Instrumented libraries: move build-flags-related logic to the GYP file. - Keep both the general and package-specific CFLAGS/LDFLAGS in the GYP file, and pass only the final flags to the script. This allows us to simplify things somewhat, as well as easily change the build flags based on GYP defines. - Consequently, the global msan_track_origins GYP flag now also affects instrumented libraries. - I also threw in a mass renaming "library" -> "package". BUG=313751 R=glider@chromium.org NOTRY=true TEST=MSan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279699

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+209 lines, -255 lines)			Patch
M	third_party/instrumented_libraries/download_build_install.py	View	6 chunks	+41 lines, -70 lines	0 comments	Download
M	third_party/instrumented_libraries/instrumented_libraries.gyp	View	13 chunks	+156 lines, -125 lines	0 comments	Download
D	third_party/instrumented_libraries/standard_instrumented_library_target.gypi	View	1 chunk	+0 lines, -47 lines	0 comments	Download
A +	third_party/instrumented_libraries/standard_instrumented_package_target.gypi	View	1 chunk	+12 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

earthdok

PTAL I think we might be able to get rid of the includes/dependencies copypasta as ...

6 years, 6 months ago (2014-06-24 18:30:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/337613008/1

6 years, 6 months ago (2014-06-25 12:27:15 UTC) #4

Message was sent while issue was closed.

Change committed as 279699

Expand Messages | Collapse Messages