Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 337613004: Isolate nacl_loader_unittests (Closed)

Created:
6 years, 6 months ago by jln (very slow on Chromium)
Modified:
6 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Isolate nacl_loader_unittests Isolate the Linux-only nacl_loader_unittests. This is a re-land of https://chromiumcodereview.appspot.com/322333006/ BUG=384515 TBR=maruel Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278882

Patch Set 1 #

Patch Set 2 : Don't build if disable_nacl==1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M components/nacl.gyp View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + components/nacl_loader_unittests.isolate View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 6 months ago (2014-06-20 22:42:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/337613004/20001
6 years, 6 months ago (2014-06-20 22:43:49 UTC) #2
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 6 months ago (2014-06-20 22:58:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/337613004/40001
6 years, 6 months ago (2014-06-20 23:00:04 UTC) #4
jln (very slow on Chromium)
6 years, 6 months ago (2014-06-21 00:46:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r278882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698