Issue 337603010: Remove static initializer from isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337603010: Remove static initializer from isolate (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 5 months ago

Reviewers:
dcarney, Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Remove static initializer from isolate We don't have a default isolate anymore, so we can just create the thread data and keys on demand BUG=none R=dcarney@chromium.org, svenpanne@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=22105

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -40 lines)			Patch
M	src/isolate.h	View	3 chunks	+3 lines, -8 lines	0 comments	Download
M	src/isolate.cc	View	6 chunks	+10 lines, -28 lines	0 comments	Download
M	src/mksnapshot.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/cctest/cctest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/check-static-initializers.sh	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Sven Panne

LGTM. I think we slowly approach the point where we can merge Isolate::Init into Isolate::Isolate ...

6 years, 5 months ago (2014-07-01 06:14:52 UTC) #3

jochen (gone - plz use gerrit)

6 years, 5 months ago (2014-07-01 06:46:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22105 (presubmit successful).