Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 337603008: Remove A8_LCD luminance hack. (Closed)

Created:
6 years, 5 months ago by jvanverth1
Modified:
6 years, 5 months ago
Reviewers:
bungeman-skia, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove A8_LCD luminance hack. It no longer appears to be necessary, and the powf function is slowing down Android text rendering. Committed: https://skia.googlesource.com/skia/+/dc1cf66483e93c2d12d938bc1ce3b8c60cc68da5

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Patch Set 3 : Add SK_IGNORE_FASTER_TEXT_FIX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -2 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +94 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 2 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jvanverth1
Moved from https://codereview.chromium.org/348153002/ since a it's completely different approach. After another perf pass, this does ...
6 years, 5 months ago (2014-06-30 20:02:34 UTC) #1
bsalomon
I defer to Ben.
6 years, 5 months ago (2014-06-30 20:06:34 UTC) #2
jvanverth1
Ben, can you take a look today, please?
6 years, 5 months ago (2014-07-01 14:02:36 UTC) #3
bungeman-skia
On 2014/07/01 14:02:36, jvanverth1 wrote: > Ben, can you take a look today, please? I ...
6 years, 5 months ago (2014-07-01 16:52:02 UTC) #4
bungeman-skia
On 2014/07/01 16:52:02, bungeman1 wrote: > On 2014/07/01 14:02:36, jvanverth1 wrote: > > Ben, can ...
6 years, 5 months ago (2014-07-01 17:07:46 UTC) #5
jvanverth1
On 2014/07/01 17:07:46, bungeman1 wrote: > On 2014/07/01 16:52:02, bungeman1 wrote: > > On 2014/07/01 ...
6 years, 5 months ago (2014-07-01 17:51:07 UTC) #6
bungeman-skia
On 2014/07/01 17:51:07, jvanverth1 wrote: > On 2014/07/01 17:07:46, bungeman1 wrote: > > On 2014/07/01 ...
6 years, 5 months ago (2014-07-01 20:24:53 UTC) #7
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 5 months ago (2014-07-01 20:26:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/337603008/40001
6 years, 5 months ago (2014-07-01 20:26:29 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 20:43:04 UTC) #10
Message was sent while issue was closed.
Change committed as dc1cf66483e93c2d12d938bc1ce3b8c60cc68da5

Powered by Google App Engine
This is Rietveld 408576698