Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: net/cert/multi_log_ct_verifier.cc

Issue 337603003: Certificate Transparency: Switch to using a generated CT log list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switched to defining the size of the log_key array in the type definition Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/multi_log_ct_verifier.h ('k') | net/net.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/multi_log_ct_verifier.cc
diff --git a/net/cert/multi_log_ct_verifier.cc b/net/cert/multi_log_ct_verifier.cc
index 5094da026d03f38bf8cee4c54c7cea5ce2f32580..c0e96c528e1ccd3b2c18734364bad26147021eb8 100644
--- a/net/cert/multi_log_ct_verifier.cc
+++ b/net/cert/multi_log_ct_verifier.cc
@@ -4,6 +4,8 @@
#include "net/cert/multi_log_ct_verifier.h"
+#include <vector>
Ryan Sleevi 2014/06/19 00:34:08 Do you actually still need vector? Seems like no.
Eran Messeri 2014/06/19 08:28:37 std::vector is actually used in a different method
+
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/metrics/histogram.h"
@@ -66,6 +68,18 @@ void MultiLogCTVerifier::AddLog(scoped_ptr<CTLogVerifier> log_verifier) {
logs_[log->key_id()] = log;
}
+void MultiLogCTVerifier::AddLogs(
+ ScopedVector<CTLogVerifier> log_verifiers) {
+ for (ScopedVector<CTLogVerifier>::iterator it =
+ log_verifiers.begin(); it != log_verifiers.end(); ++it) {
+ linked_ptr<CTLogVerifier> log(*it);
+ VLOG(1) << "Adding CT log: " << log->description();
+ logs_[log->key_id()] = log;
+ }
+
+ log_verifiers.weak_clear();
Ryan Sleevi 2014/06/19 00:34:08 nit: add comment // Ownership of the pointers in |
Eran Messeri 2014/06/19 08:28:37 Done.
+}
+
int MultiLogCTVerifier::Verify(
X509Certificate* cert,
const std::string& stapled_ocsp_response,
« no previous file with comments | « net/cert/multi_log_ct_verifier.h ('k') | net/net.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698